Implement string comparison#115
Open
alvra wants to merge 3 commits into
Open
Conversation
AaronFeickert
suggested changes
Feb 12, 2024
AaronFeickert
left a comment
AaronFeickert
left a comment
Contributor
There was a problem hiding this comment.
It may be useful to document that this will short-circuit if the strings do not have the same length.
Author
|
I've added a note similar to the one for slices. |
AaronFeickert
suggested changes
Feb 13, 2024
AaronFeickert
left a comment
AaronFeickert
left a comment
Contributor
There was a problem hiding this comment.
It would also be helpful to add a few tests for this.
AaronFeickert
approved these changes
Feb 18, 2024
|
I'm interested in this change. Is there anything blocking it? The workaround is very simple, just call |
|
Would love to see this get merged too. Any blockers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
ConstantTimeEqforstr.