Make dandi download -i <instance> run in a Dandiset download that Dandiset

[jwodder]

Closes #153.

Note that the tests for this change must be run with DANDI_DEVEL=1, which also enables test_enormous_upload_breaks_girder. As a result, the new tests are not run under CI.

[codecov]

Codecov Report

Merging #383 (e20cc96) into master (efc76ec) will decrease coverage by 0.36%.
The diff coverage is 29.82%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   65.56%   65.20%   -0.37%     
==========================================
  Files          55       55              
  Lines        5652     5707      +55     
==========================================
+ Hits         3706     3721      +15     
- Misses       1946     1986      +40     

Flag	Coverage Δ
unittests	65.20% <29.82%> (-0.37%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dandi/cli/cmd_download.py	66.66% <27.27%> (-30.11%)	⬇️
dandi/cli/tests/test_download.py	63.63% <31.42%> (-36.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc76ec...e20cc96. Read the comment docs.

[yarikoptic]

Closes #153.

Note that the tests for this change must be run with DANDI_DEVEL=1, which also enables test_enormous_upload_breaks_girder. As a result, the new tests are not run under CI.

couldn't those specific tests mock patch env just for their own CliRunner invocation?

[jwodder]

@yarikoptic No, DANDI_DEVEL needs to be set when the code is loaded in order for the --dandi-instance option to be available.

[yarikoptic]

oh, ok. Thanks for the explanation. Let's proceed then as is