Skip to content

Delete functions (get_asset_metadata, find_dandi_files) obsoleted by PR #853 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yarikoptic merged 1 commit into from
Jan 26, 2022
Merged

Delete functions (get_asset_metadata, find_dandi_files) obsoleted by PR #853 #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions dandi/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,28 +788,6 @@ def process_ndtypes(asset, nd_types):
return asset


def get_asset_metadata(
filepath, relpath, digest: Optional[Digest] = None, allow_any_path=True
) -> models.BareAsset:
metadata = None
if op.splitext(filepath)[1] == ".nwb":
try:
metadata = nwb2asset(filepath, digest=digest)
except Exception as e:
lgr.warning(
"Failed to extract NWB metadata from %s: %s: %s",
filepath,
type(e).__name__,
str(e),
)
if not allow_any_path:
raise
if metadata is None:
metadata = get_default_metadata(filepath, digest=digest)
metadata.path = str(relpath)
return metadata


def nwb2asset(
nwb_path, digest: Optional[Digest] = None, schema_version=None
) -> models.BareAsset:
Expand Down
6 changes: 0 additions & 6 deletions dandi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,6 @@ def move_file(src, dst):
return shutil.move(src, dst)


def find_dandi_files(paths):
"""Adapter to find_files to find files of interest to dandi project"""
sep = re.escape(os.sep)
yield from find_files(rf"((^|{sep})dandiset\.yaml|\.nwb)\Z", paths)


def find_parent_directory_containing(filename, path=None):
"""Find a directory, on the path to 'path' containing filename

Expand Down