`load-db` fails with "Invalid token" when clj-kondo produces TokenNode values for :name in var-definitions

[DeLaGuardo]

When analyzing a project that uses certain macros that expands to def, clj-kondo's :var-definitions analysis can produce clj_kondo.impl.rewrite_clj.node.token.TokenNode objects instead of plain symbols for the :name field of some entries.

clj-xref.analyze/transform-var-def copies this value as-is into :local-name

In memory, these TokenNode objects work fine — (str token-node) returns the correct string. But when clj-xref.emit/write-edn serializes the database with prn, the TokenNode's print representation is <token: Foo>, which is not valid EDN. This causes clj-xref.emit/read-edn (and therefore clj-xref.core/load-db) to fail:

Execution error at clj-xref.emit/read-edn (emit.clj:56).
Invalid token: <token:

Looks like the one way to fix it is to coerce :local-name to a symbol in transform-var-def:

:local-name (:name vd)
;; to:
:local-name (symbol (str (:name vd)))

[danlentz]

Been thinking about this over the weekend. 0.1.1 will address this particular edge, and also make db-loading more resilient in general. But then I think things will get even a lot better once I have a general solution to macros. Kondo is great, but we need to look at maybe fdeps and/or ASM bytecode to go get there. ASM might be more favorable, since we could still do it out-process.