Skip to content

add image pull policy#1462

Merged
yaron2 merged 10 commits into
dapr:masterfrom
filintod:filinto/add-image-pull-policy
Jan 7, 2025
Merged

add image pull policy#1462
yaron2 merged 10 commits into
dapr:masterfrom
filintod:filinto/add-image-pull-policy

Conversation

@filintod

@filintod filintod commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Description

Currently one cannot use the kubernetes run when using an image loaded to a kind cluster as the image pull policy is hard coded to Always. This changes it to make it configurable.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1463

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@filintod filintod requested review from a team as code owners November 12, 2024 18:40
Signed-off-by: Filinto Duran <filinto@diagrid.io>
@filintod filintod force-pushed the filinto/add-image-pull-policy branch from a170e7c to 448ecae Compare November 12, 2024 18:44
Signed-off-by: Filinto Duran <filinto@diagrid.io>
@filintod

Copy link
Copy Markdown
Contributor Author

@artursouza @antontroshin please check

antontroshin
antontroshin previously approved these changes Nov 14, 2024
Comment thread pkg/runfileconfig/run_file_config_parser.go Outdated
elena-kolevska
elena-kolevska previously approved these changes Nov 14, 2024
Signed-off-by: Filinto Duran <filinto@diagrid.io>
@filintod filintod dismissed stale reviews from elena-kolevska and antontroshin via 9783d1b November 14, 2024 14:38
@filintod

Copy link
Copy Markdown
Contributor Author

@antontroshin @elena-kolevska could you re-approved? I added the feedback from @antontroshin

@elena-kolevska elena-kolevska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Filinto Duran <filinto@diagrid.io>
@filintod

Copy link
Copy Markdown
Contributor Author

@elena-kolevska please take another look. thx

@elena-kolevska elena-kolevska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter is failing, but other than that, lgtm

Filinto Duran added 2 commits November 14, 2024 10:48
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Filinto Duran added 2 commits November 14, 2024 11:03
Signed-off-by: Filinto Duran <filinto@diagrid.io>
Signed-off-by: Filinto Duran <filinto@diagrid.io>

@elena-kolevska elena-kolevska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful for local development @filintod , thank you very much!

@yaron2

yaron2 commented Dec 23, 2024

Copy link
Copy Markdown
Member

Upgrade tests are failing, is this related?

@antontroshin

Copy link
Copy Markdown
Contributor

@yaron2 I've re-run the tests, and they all passed, except for regular Podman failure on macOS, which is on my plate for the near future.
IMO, g2g.

@yaron2 yaron2 merged commit efe1d6c into dapr:master Jan 7, 2025
@marcduiker

Copy link
Copy Markdown
Contributor

@holopin-bot @filintod Thanks Filinto!

@holopin-bot

holopin-bot Bot commented Jan 10, 2025

Copy link
Copy Markdown

Congratulations @filintod, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qxul0p17180clbbpi58lsp

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Image Pull Policy for dapr run on kubernetes

6 participants