add image pull policy#1462
Conversation
Signed-off-by: Filinto Duran <filinto@diagrid.io>
a170e7c to
448ecae
Compare
Signed-off-by: Filinto Duran <filinto@diagrid.io>
|
@artursouza @antontroshin please check |
Signed-off-by: Filinto Duran <filinto@diagrid.io>
9783d1b
|
@antontroshin @elena-kolevska could you re-approved? I added the feedback from @antontroshin |
elena-kolevska
left a comment
There was a problem hiding this comment.
Can we add a little unit test pls?
https://github.com/dapr/cli/blob/master/pkg/runfileconfig/run_file_config_parser_test.go
Signed-off-by: Filinto Duran <filinto@diagrid.io>
|
@elena-kolevska please take another look. thx |
elena-kolevska
left a comment
There was a problem hiding this comment.
Linter is failing, but other than that, lgtm
elena-kolevska
left a comment
There was a problem hiding this comment.
Super helpful for local development @filintod , thank you very much!
|
Upgrade tests are failing, is this related? |
|
@yaron2 I've re-run the tests, and they all passed, except for regular Podman failure on macOS, which is on my plate for the near future. |
|
@holopin-bot @filintod Thanks Filinto! |
|
Congratulations @filintod, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qxul0p17180clbbpi58lsp This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Description
Currently one cannot use the kubernetes run when using an image loaded to a kind cluster as the image pull policy is hard coded to Always. This changes it to make it configurable.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1463
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: