Skip to content

state store query API: remove 'value' prefix from key names#2195

Merged
msfussell merged 1 commit into
dapr:v1.7from
dmitsh:ds-query
Feb 15, 2022
Merged

state store query API: remove 'value' prefix from key names#2195
msfussell merged 1 commit into
dapr:v1.7from
dmitsh:ds-query

Conversation

@dmitsh

@dmitsh dmitsh commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Remove 'value' prefix from key names in statestore query API

Issue reference

#2191

@dmitsh dmitsh requested review from a team as code owners February 11, 2022 21:59
@msfussell

msfussell commented Feb 11, 2022

Copy link
Copy Markdown
Member

@dmitsh - Will leave you to fix this to remove the dot notation

@dmitsh

dmitsh commented Feb 12, 2022

Copy link
Copy Markdown
Contributor Author

@dmitsh - Will leave you to fix this to remove the dot notation

done + some extra text

@dmitsh dmitsh requested a review from msfussell February 12, 2022 00:40
msfussell
msfussell reviewed Feb 12, 2022
View reviewed changes
Comment thread daprdocs/content/en/reference/api/state_api.md Outdated
msfussell
msfussell reviewed Feb 12, 2022
View reviewed changes
Comment thread daprdocs/content/en/reference/api/state_api.md Outdated
msfussell
msfussell reviewed Feb 12, 2022
View reviewed changes

@msfussell msfussell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few more dots to check

Comment thread daprdocs/content/en/reference/api/state_api.md Outdated
Comment thread daprdocs/content/en/reference/api/state_api.md Outdated
Comment thread daprdocs/content/en/reference/api/state_api.md Outdated
@dmitsh
state store query API: remove 'value' prefix from key names
34b6dcb 
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>
@dmitsh dmitsh requested a review from msfussell February 12, 2022 01:57
This was referenced Feb 14, 2022
Open
Open
Open
Open
Closed
Closed
Closed
Closed
Closed
msfussell
msfussell approved these changes Feb 15, 2022
View reviewed changes

@msfussell msfussell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit d2503bc into dapr:v1.7 Feb 15, 2022
@dmitsh dmitsh deleted the ds-query branch February 25, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfussell msfussell msfussell approved these changes

Assignees

@dmitsh dmitsh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitsh @msfussell