use v1.18.0#1766
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Updates this Java SDK repo’s Dapr dependency pins to target the Dapr runtime/proto v1.18.0 release, including CI workflow environment variables that control which Dapr runtime/CLI versions are installed during builds.
Changes:
- Bump
dapr.proto.baseurlinpom.xmlfromv1.18.0-rc.4tov1.18.0. - Update GitHub Actions workflows to use
DAPR_RUNTIME_VER: 1.18.0. - Update GitHub Actions workflows to use
DAPR_CLI_VER: 1.18.0and av1.18.0CLI install script URL (currently problematic due to missing tag).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pom.xml |
Points proto downloads at Dapr runtime v1.18.0 instead of the RC tag. |
.github/workflows/validate.yml |
Updates the Dapr CLI/runtime versions used when validating examples. |
.github/workflows/build.yml |
Updates the Dapr CLI/runtime versions used in CI build/integration testing jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
this will fail bc the cli is not released yet |
|
I think you are missing test container config |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
============================================
- Coverage 76.86% 76.83% -0.03%
+ Complexity 2298 2297 -1
============================================
Files 243 243
Lines 7141 7141
Branches 745 745
============================================
- Hits 5489 5487 -2
- Misses 1287 1288 +1
- Partials 365 366 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
use v1.18.0