Skip to content

add metadata in get bulk state request#401

Merged
artursouza merged 8 commits into
dapr:masterfrom
skyao:add-metadata-in-bulk-get-state
Dec 29, 2020
Merged

add metadata in get bulk state request#401
artursouza merged 8 commits into
dapr:masterfrom
skyao:add-metadata-in-bulk-get-state

Conversation

@skyao

@skyao skyao commented Dec 3, 2020

Copy link
Copy Markdown
Member

Description

Add metadata filed in get bulk state request.

Issue reference

#396

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, update unit tests to use metadata and keep code coverage.

@mukundansundar

mukundansundar commented Dec 14, 2020

Copy link
Copy Markdown
Contributor

LGTM. Please, update unit tests to use metadata and keep code coverage.

@skyao can you look into this comment and add tests.
The PR is much appreciated 💯

@skyao

skyao commented Dec 29, 2020

Copy link
Copy Markdown
Member Author

LGTM. Please, update unit tests to use metadata and keep code coverage.

@skyao can you look into this comment and add tests.
The PR is much appreciated 💯

Unit test updated. Help to review this PR again.

Thanks.

@codecov

codecov Bot commented Dec 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #401 (c55240a) into master (08f133d) will decrease coverage by 0.06%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
- Coverage     83.52%   83.46%   -0.07%     
- Complexity      838      841       +3     
============================================
  Files            72       72              
  Lines          2489     2497       +8     
  Branches        259      260       +1     
============================================
+ Hits           2079     2084       +5     
- Misses          286      287       +1     
- Partials        124      126       +2     
Impacted Files Coverage Δ Complexity Δ
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 85.23% <0.00%> (-0.58%) 86.00 <0.00> (ø)
...dapr/client/domain/GetBulkStateRequestBuilder.java 81.81% <66.66%> (-2.40%) 4.00 <1.00> (+1.00) ⬇️
...ava/io/dapr/client/domain/GetBulkStateRequest.java 100.00% <100.00%> (ø) 11.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f133d...5ffbb63. Read the comment docs.

@artursouza artursouza merged commit b5dd421 into dapr:master Dec 29, 2020
@skyao skyao deleted the add-metadata-in-bulk-get-state branch December 30, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants