Skip to content

Fix samples for release 1 rc2#416

Merged
artursouza merged 1 commit into
dapr:release-1.0from
artursouza:fix_samples_releaser_1_rc2
Dec 16, 2020
Merged

Fix samples for release 1 rc2#416
artursouza merged 1 commit into
dapr:release-1.0from
artursouza:fix_samples_releaser_1_rc2

Conversation

@artursouza

Copy link
Copy Markdown
Contributor

Description

Fix samples releaser 1 rc2

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: end game

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza changed the base branch from master to release-1.0 December 16, 2020 07:12
@codecov

codecov Bot commented Dec 16, 2020

Copy link
Copy Markdown

Codecov Report

Merging #416 (f0caeb7) into release-1.0 (17c9690) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.0     #416   +/-   ##
==============================================
  Coverage          83.26%   83.26%           
  Complexity           835      835           
==============================================
  Files                 72       72           
  Lines               2486     2486           
  Branches             255      255           
==============================================
  Hits                2070     2070           
  Misses               293      293           
  Partials             123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c9690...f0caeb7. Read the comment docs.

@mukundansundar mukundansundar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@artursouza artursouza changed the title Fix samples releaser 1 rc2 Fix samples for release 1 rc2 Dec 16, 2020
@artursouza artursouza merged commit db9166e into dapr:release-1.0 Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants