Skip to content

Rename ActorProxy invoke to invokeMethod.#420

Merged
artursouza merged 3 commits into
dapr:masterfrom
He-Pin:invokeMethod
Dec 18, 2020
Merged

Rename ActorProxy invoke to invokeMethod.#420
artursouza merged 3 commits into
dapr:masterfrom
He-Pin:invokeMethod

Conversation

@He-Pin

@He-Pin He-Pin commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Description

Rename ActorProxy invoke to invokeMethod.

Issue reference

refs:#418

Please reference the issue this PR will close: #418

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ x] Code compiles correctly
  • [ x] Created/updated tests
  • [ x] Extended the documentation

@ghost

ghost commented Dec 17, 2020

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@mukundansundar

Copy link
Copy Markdown
Contributor

Hi @hepin1989 thanks for this PR. Can you comment /assign on the issue so that it can be assigned to you?

@mukundansundar mukundansundar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment thread docs/index-all.html Outdated

@mukundansundar mukundansundar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Dec 18, 2020

Copy link
Copy Markdown

Codecov Report

Merging #420 (5e07c9d) into master (a35e414) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
  Complexity      838      838           
=========================================
  Files            72       72           
  Lines          2493     2493           
  Branches        258      258           
=========================================
  Hits           2075     2075           
  Misses          294      294           
  Partials        124      124           
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/dapr/actors/client/ActorProxyImpl.java 90.24% <100.00%> (ø) 24.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a35e414...5e07c9d. Read the comment docs.

@artursouza artursouza merged commit 3b51b5b into dapr:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename invoke to invokeMethod for ActorProxy

3 participants