Skip to content

Throws IllegalArgumentException without wrapping as DaprException.#426

Merged
artursouza merged 1 commit into
dapr:masterfrom
artursouza:throws_illegalargument
Dec 22, 2020
Merged

Throws IllegalArgumentException without wrapping as DaprException.#426
artursouza merged 1 commit into
dapr:masterfrom
artursouza:throws_illegalargument

Conversation

@artursouza

Copy link
Copy Markdown
Contributor

Description

Throws IllegalArgumentException without wrapping as DaprException.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #424

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

rynowak
rynowak previously approved these changes Dec 21, 2020
@codecov

codecov Bot commented Dec 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #426 (d3e30a2) into master (3b51b5b) will increase coverage by 0.29%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #426      +/-   ##
============================================
+ Coverage     83.23%   83.52%   +0.29%     
  Complexity      838      838              
============================================
  Files            72       72              
  Lines          2493     2489       -4     
  Branches        258      259       +1     
============================================
+ Hits           2075     2079       +4     
+ Misses          294      286       -8     
  Partials        124      124              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/dapr/exceptions/DaprException.java 78.04% <40.00%> (+1.85%) 15.00 <0.00> (ø)
.../java/io/dapr/actors/client/ActorProxyBuilder.java 63.15% <60.00%> (+7.89%) 10.00 <0.00> (ø)
...rc/main/java/io/dapr/client/DaprClientBuilder.java 70.96% <75.00%> (+9.67%) 8.00 <0.00> (ø)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 93.10% <100.00%> (+0.30%) 80.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b51b5b...b2858b9. Read the comment docs.

@artursouza artursouza merged commit 08f133d into dapr:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unwrap IllegalArgumentException

3 participants