Skip to content

Refactor to move duplicate code to method#429

Merged
artursouza merged 2 commits into
dapr:masterfrom
arghya88:refactor
Dec 29, 2020
Merged

Refactor to move duplicate code to method#429
artursouza merged 2 commits into
dapr:masterfrom
arghya88:refactor

Conversation

@arghya88

@arghya88 arghya88 commented Dec 23, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: Arghya Sadhu arghya88@gmail.com

Description

refactor to move duplicate code to method

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

RELEASE NOTE: N/A

Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
@arghya88 arghya88 changed the title refactor to move duplicate code to method Refactor to move duplicate code to method Dec 23, 2020
@codecov

codecov Bot commented Dec 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #429 (d56c730) into master (b5dd421) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #429      +/-   ##
============================================
- Coverage     83.46%   83.40%   -0.06%     
+ Complexity      841      839       -2     
============================================
  Files            72       72              
  Lines          2497     2489       -8     
  Branches        260      259       -1     
============================================
- Hits           2084     2076       -8     
  Misses          287      287              
  Partials        126      126              
Impacted Files Coverage Δ Complexity Δ
...k/src/main/java/io/dapr/client/DaprClientHttp.java 92.88% <100.00%> (-0.22%) 78.00 <4.00> (-2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5dd421...84f1850. Read the comment docs.

@artursouza artursouza merged commit 4c1773c into dapr:master Dec 29, 2020
@arghya88 arghya88 deleted the refactor branch December 30, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants