Skip to content

Adds method to wait for Dapr sidecar.#433

Merged
artursouza merged 1 commit into
dapr:masterfrom
artursouza:wait_api
Dec 31, 2020
Merged

Adds method to wait for Dapr sidecar.#433
artursouza merged 1 commit into
dapr:masterfrom
artursouza:wait_api

Conversation

@artursouza

Copy link
Copy Markdown
Contributor

Description

Adds method to wait for Dapr sidecar.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #377

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested a review from wcs1only December 31, 2020 03:08
@codecov

codecov Bot commented Dec 31, 2020

Copy link
Copy Markdown

Codecov Report

Merging #433 (2db73a9) into master (1a6675a) will decrease coverage by 0.10%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #433      +/-   ##
============================================
- Coverage     83.39%   83.28%   -0.11%     
- Complexity      840      850      +10     
============================================
  Files            72       74       +2     
  Lines          2481     2519      +38     
  Branches        254      256       +2     
============================================
+ Hits           2069     2098      +29     
- Misses          292      299       +7     
- Partials        120      122       +2     
Impacted Files Coverage Δ Complexity Δ
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 83.54% <66.66%> (-0.34%) 88.00 <2.00> (+2.00) ⬇️
...k/src/main/java/io/dapr/client/DaprClientHttp.java 92.06% <66.66%> (-0.62%) 80.00 <2.00> (+2.00) ⬇️
sdk/src/main/java/io/dapr/utils/NetworkUtils.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
sdk/src/main/java/io/dapr/config/Property.java 68.42% <0.00%> (+10.52%) 7.00% <0.00%> (+2.00%)
.../src/main/java/io/dapr/config/IntegerProperty.java 100.00% <0.00%> (+33.33%) 2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a6675a...edce2e0. Read the comment docs.

@wcs1only wcs1only left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit 6a44d51 into dapr:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add wait() method to block until Sidecar is up

2 participants