Skip to content

Fix handling of metadata, headers. Removes etag from getState.#440

Merged
artursouza merged 3 commits into
dapr:masterfrom
artursouza:fix_metadata
Jan 14, 2021
Merged

Fix handling of metadata, headers. Removes etag from getState.#440
artursouza merged 3 commits into
dapr:masterfrom
artursouza:fix_metadata

Conversation

@artursouza

Copy link
Copy Markdown
Contributor

Description

Fix handling of metadata, headers.
Removes etag from getState.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #439 #396

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov

codecov Bot commented Jan 14, 2021

Copy link
Copy Markdown

Codecov Report

Merging #440 (0991195) into master (76d877c) will increase coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #440      +/-   ##
============================================
+ Coverage     83.30%   83.32%   +0.01%     
+ Complexity      859      858       -1     
============================================
  Files            74       74              
  Lines          2540     2548       +8     
  Branches        256      259       +3     
============================================
+ Hits           2116     2123       +7     
+ Misses          302      299       -3     
- Partials        122      126       +4     
Impacted Files Coverage Δ Complexity Δ
...in/java/io/dapr/client/domain/GetStateRequest.java 100.00% <ø> (ø) 12.00 <0.00> (-2.00)
.../io/dapr/client/domain/GetStateRequestBuilder.java 82.35% <ø> (-2.65%) 4.00 <0.00> (-1.00)
...va/io/dapr/client/domain/InvokeServiceRequest.java 100.00% <ø> (+4.54%) 13.00 <0.00> (-1.00) ⬆️
...apr/client/domain/InvokeServiceRequestBuilder.java 90.47% <ø> (-1.53%) 5.00 <0.00> (-2.00)
...c/main/java/io/dapr/client/AbstractDaprClient.java 89.55% <40.00%> (-0.31%) 33.00 <2.00> (ø)
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 82.97% <73.33%> (-0.31%) 94.00 <0.00> (ø)
...main/java/io/dapr/client/domain/HttpExtension.java 95.23% <94.44%> (+8.87%) 8.00 <6.00> (+3.00)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 91.85% <94.59%> (-0.22%) 82.00 <4.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d877c...0991195. Read the comment docs.

@mukundansundar mukundansundar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artursouza @yaron2 We need to validate whether the metadata is being passed correctly in other SDKs as well.

@artursouza artursouza merged commit 019dee9 into dapr:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused eTag param from getState()

2 participants