Skip to content

Makes http call async and allows timeout in Mono.#445

Merged
artursouza merged 2 commits into
dapr:masterfrom
artursouza:timeout
Jan 21, 2021
Merged

Makes http call async and allows timeout in Mono.#445
artursouza merged 2 commits into
dapr:masterfrom
artursouza:timeout

Conversation

@artursouza

@artursouza artursouza commented Jan 19, 2021

Copy link
Copy Markdown
Contributor

Description

Makes http call async and allows timeout in Mono.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

will close: #434
will close: #399

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from mukundansundar and skyao and removed request for skyao January 19, 2021 01:10
@codecov

codecov Bot commented Jan 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #445 (2065b8c) into master (446cd17) will decrease coverage by 0.16%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #445      +/-   ##
============================================
- Coverage     83.28%   83.11%   -0.17%     
+ Complexity      862      858       -4     
============================================
  Files            74       74              
  Lines          2554     2565      +11     
  Branches        261      261              
============================================
+ Hits           2127     2132       +5     
- Misses          299      304       +5     
- Partials        128      129       +1     
Impacted Files Coverage Δ Complexity Δ
sdk/src/main/java/io/dapr/client/DaprHttp.java 88.57% <87.50%> (-0.80%) 23.00 <2.00> (-3.00)
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <0.00%> (-25.00%) 1.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446cd17...2065b8c. Read the comment docs.

@wcs1only wcs1only left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artursouza artursouza merged commit 81b47f8 into dapr:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blocking calls for gRPC and HTTP even though using Reactor How to set timeout invoking service

2 participants