Skip to content

Makes service method API invocations over HTTP by default.#450

Merged
artursouza merged 2 commits into
dapr:masterfrom
artursouza:http_invoke
Jan 23, 2021
Merged

Makes service method API invocations over HTTP by default.#450
artursouza merged 2 commits into
dapr:masterfrom
artursouza:http_invoke

Conversation

@artursouza

Copy link
Copy Markdown
Contributor

Description

Makes service method API invocations over HTTP by default.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #438

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar mukundansundar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can understand why you left it as methodInvocation in the propery and METHODINVOCATION in the env var, but I think method.invocation and METHOD_INVOCATION looks better and follows convention.

Comment thread sdk/src/main/java/io/dapr/client/DaprClientBuilder.java Outdated
Comment thread sdk/src/main/java/io/dapr/config/Properties.java Outdated
Comment thread sdk/src/main/java/io/dapr/config/Properties.java
Comment thread sdk-actors/src/main/java/io/dapr/actors/runtime/ActorRuntime.java
@codecov

codecov Bot commented Jan 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #450 (ffde75f) into master (38b899d) will decrease coverage by 0.34%.
The diff coverage is 67.04%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #450      +/-   ##
============================================
- Coverage     83.30%   82.95%   -0.35%     
- Complexity      861      900      +39     
============================================
  Files            74       76       +2     
  Lines          2569     2640      +71     
  Branches        261      263       +2     
============================================
+ Hits           2140     2190      +50     
- Misses          301      322      +21     
  Partials        128      128              
Impacted Files Coverage Δ Complexity Δ
...main/java/io/dapr/actors/runtime/ActorRuntime.java 56.16% <0.00%> (ø) 20.00 <0.00> (ø)
...rc/main/java/io/dapr/client/DaprClientBuilder.java 68.42% <45.45%> (-2.55%) 11.00 <3.00> (+3.00) ⬇️
.../java/io/dapr/actors/client/ActorProxyBuilder.java 63.41% <60.00%> (+0.25%) 11.00 <6.00> (+1.00)
sdk/src/main/java/io/dapr/config/Properties.java 77.77% <71.42%> (-7.94%) 1.00 <0.00> (ø)
.../src/main/java/io/dapr/client/DaprClientProxy.java 72.22% <72.22%> (ø) 33.00 <33.00> (?)
.../src/main/java/io/dapr/client/DaprApiProtocol.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../src/main/java/io/dapr/client/DaprHttpBuilder.java 81.25% <100.00%> (ø) 5.00 <0.00> (ø)
.../src/main/java/io/dapr/config/BooleanProperty.java 0.00% <0.00%> (-66.67%) 0.00% <0.00%> (-1.00%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b899d...ffde75f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle service invocation over HTTP only

2 participants