Skip to content

fix examples for latest rc. validate build with latest rc#487

Merged
artursouza merged 1 commit into
dapr:masterfrom
mukundansundar:fix-examples-latest-rc
Feb 12, 2021
Merged

fix examples for latest rc. validate build with latest rc#487
artursouza merged 1 commit into
dapr:masterfrom
mukundansundar:fix-examples-latest-rc

Conversation

@mukundansundar

@mukundansundar mukundansundar commented Feb 12, 2021

Copy link
Copy Markdown
Contributor

Description

Fix examples for latest RC.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar mukundansundar marked this pull request as ready for review February 12, 2021 00:38
@codecov

codecov Bot commented Feb 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #487 (67b6a02) into master (e46ef31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage     80.18%   80.18%           
  Complexity      967      967           
=========================================
  Files            88       88           
  Lines          3003     3003           
  Branches        329      329           
=========================================
  Hits           2408     2408           
  Misses          429      429           
  Partials        166      166           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46ef31...6a0e7fc. Read the comment docs.

@artursouza artursouza mentioned this pull request Feb 12, 2021
3 tasks
JDK_VER: 13.0.x
DAPR_CLI_VER: 1.0.0-rc.4
DAPR_RUNTIME_VER: 1.0.0-rc.3
DAPR_CLI_VER: 1.0.0-rc.5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I forgot we have this now.

@artursouza artursouza merged commit 0a826d0 into dapr:master Feb 12, 2021
@mukundansundar mukundansundar deleted the fix-examples-latest-rc branch February 12, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants