Adjusted the configuration of Maven. by LLLLimbo · Pull Request #532 · dapr/java-sdk

LLLLimbo · 2021-03-31T06:29:10Z

Description

Adjusted the configuration of Maven.

Issue reference

#531

ghost · 2021-03-31T06:29:22Z

All CLA requirements met.

artursouza

Please, help me understand the motivation for this PR.

artursouza · 2021-04-03T02:00:58Z

+        <version>${junit-jupiter-engine.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>com.github.stefanbirkner</groupId>


Why are you moving these dependencies to the parent pom? Many of these dependencies are supposed to be only in the examples pom. Does it mean all the projects will share the same dependencies?

No, this does not mean that all projects will share dependencies. The dependency will only really be introduced when some project references it in dependencies.
I moved the dependencies to the dependencyManagement of the parent pom, so that the project does not have to specify a version when referring to them, and it is easy to manage.

artursouza · 2021-04-03T02:03:28Z

-    </plugins>
+    <extensions>
+      <extension>
+        <groupId>kr.motd.maven</groupId>


Why we need this plugin?

It is used to detect the information about the current operating system and normalize it into more portable one.
It was an oversight on my part to add it in.

artursouza · 2021-04-03T02:20:00Z

+        </plugin>
+
+        <plugin>
+          <groupId>org.springframework.boot</groupId>


Springboot cannot be a plugin required in the root project. Springboot is only used in the springboot project.

It seems an oversight too.

artursouza · 2021-04-06T21:30:55Z

-    <springboot.version>2.3.5.RELEASE</springboot.version>
  </properties>

-  <dependencyManagement>


Can you bring this back?

artursouza · 2021-04-06T21:31:20Z

      <scope>compile</scope>
    </dependency>
-      <dependency>
-          <groupId>org.springframework</groupId>


artursouza · 2021-04-06T21:32:33Z

      <scope>test</scope>
    </dependency>
-    <dependency>
-      <groupId>io.grpc</groupId>


We don't need this anymore?

We don't need this anymore?

Its duplicated to

<dependency> <groupId>io.grpc</groupId> <artifactId>grpc-stub</artifactId> </dependency>

LLLLimbo · 2021-04-06T23:54:50Z

I will wait for you to confirm the following three changes before next commit.

1.Add <version>${springboot.version}</version> of spring-boot-maven-plugin to the example，otherwise maven would not find the right version.
2. Bring spring-boot-dependencies dependency management back in sdk-springboot.
3.Add maven-compiler-plugin to the parent pom's pluginManagement，dapr-sdk-example need it.

And I still have a question for you, why the following exists in the dependencies of the example's pom, shouldn't it be a plugin?

<dependency>
      <groupId>com.github.os72</groupId>
      <artifactId>protoc-jar-maven-plugin</artifactId>
      <version>3.10.1</version>
</dependency>

artursouza · 2021-04-07T18:46:06Z

I will wait for you to confirm the following three changes before next commit.

1.Add <version>${springboot.version}</version> of spring-boot-maven-plugin to the example，otherwise maven would not find the right version.
2. Bring spring-boot-dependencies dependency management back in sdk-springboot.
3.Add maven-compiler-plugin to the parent pom's pluginManagement，dapr-sdk-example need it.

Yes to all 3 items.

And I still have a question for you, why the following exists in the dependencies of the example's pom, shouldn't it be a plugin?
<dependency>
      <groupId>com.github.os72</groupId>
      <artifactId>protoc-jar-maven-plugin</artifactId>
      <version>3.10.1</version>
</dependency>

That dependency might be wrong. Please, remove it.

Add spring-boot-dependencies dependency management in sdk-springboot. Add maven-compiler-plugin to the parent pom's pluginManagement Remove protoc-jar-maven-plugin in example's dependencies.

codecov · 2021-04-08T17:11:49Z

Codecov Report

Merging #532 (b012f6b) into master (a654861) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #532   +/-   ##
=========================================
  Coverage     80.65%   80.65%           
  Complexity      982      982           
=========================================
  Files            88       88           
  Lines          3024     3024           
  Branches        331      331           
=========================================
  Hits           2439     2439           
  Misses          420      420           
  Partials        165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a654861...b012f6b. Read the comment docs.

artursouza · 2021-04-08T17:21:39Z


  <artifactId>dapr-sdk-autogen</artifactId>
  <packaging>jar</packaging>
-  <version>1.1.0-SNAPSHOT</version>


What happens when you run this script? https://github.com/dapr/java-sdk/blob/master/scripts/update_sdk_version.sh

We use that for our release process to automatically update the version.

What happens when you run this script? https://github.com/dapr/java-sdk/blob/master/scripts/update_sdk_version.sh

We use that for our release process to automatically update the version.

It says update_sdk_version.sh: line 5: $1: unbound variable.

The variable is missing here DAPR_JAVA_SDK_VERSION=$1.
What should I do to solve this problem ?

Pass a value, like "1.2.0"

Pass a value, like "1.2.0"

Limbo@DESKTOP-GLSB8CF MINGW64 /d/gitProject/java-sdk/scripts (master) $ ./update_sdk_version.sh + DAPR_JAVA_SDK_VERSION=1.2.0 + mvn versions:set -DnewVersion=1.2.0 [INFO] Scanning for projects... [INFO] [INFO] ------------------< org.apache.maven:standalone-pom >------------------- [INFO] Building Maven Stub Project (No POM) 1 [INFO] --------------------------------[ pom ]--------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.291 s [INFO] Finished at: 2021-04-20T07:18:30+08:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.8.1:set (default-cli): Goal requires a project to execute but there is no POM in this directory (D:\gitProject\java-sdk\scripts). Please verify you invoked Maven from the correct directory. -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException

Works after I add cd .. before mvn versions

This reverts commit 5cc7981.

* Adjusted the configuration of Maven. * Update pom.xml * Remove os-maven-plugin and spring-boot-maven-plugin in parent pom * Add version of spring-boot-maven-plugin in the example pom. Add spring-boot-dependencies dependency management in sdk-springboot. Add maven-compiler-plugin to the parent pom's pluginManagement Remove protoc-jar-maven-plugin in example's dependencies. * Update pom.xml Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

This reverts commit 5cc7981. Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

Adjusted the configuration of Maven.

932846a

mukundansundar requested review from artursouza and mukundansundar March 31, 2021 16:49

Update pom.xml

02b4fc4

artursouza suggested changes Apr 3, 2021

View reviewed changes

Remove os-maven-plugin and spring-boot-maven-plugin in parent pom

0169cba

artursouza suggested changes Apr 6, 2021

View reviewed changes

LLLLimbo and others added 3 commits April 8, 2021 07:08

Add version of spring-boot-maven-plugin in the example pom.

d2cd78a

Add spring-boot-dependencies dependency management in sdk-springboot. Add maven-compiler-plugin to the parent pom's pluginManagement Remove protoc-jar-maven-plugin in example's dependencies.

Merge branch 'master' into issue_531

8bc3cab

Update pom.xml

b012f6b

artursouza reviewed Apr 8, 2021

View reviewed changes

artursouza approved these changes Apr 27, 2021

View reviewed changes

artursouza merged commit 5cc7981 into dapr:master Apr 27, 2021

artursouza added a commit that referenced this pull request Apr 30, 2021

Revert "Adjusted the configuration of Maven. (#532)" (#536)

7467575

This reverts commit 5cc7981.

fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022

Revert "Adjusted the configuration of Maven. (dapr#532)" (dapr#536)

8608f34

This reverts commit 5cc7981. Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

Uh oh!

Conversation

LLLLimbo commented Mar 31, 2021

Description

Issue reference

Uh oh!

ghost commented Mar 31, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artursouza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LLLLimbo commented Apr 6, 2021

Uh oh!

artursouza commented Apr 7, 2021

Uh oh!

codecov Bot commented Apr 8, 2021

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LLLLimbo Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghost commented Mar 31, 2021 •

edited by ghost

Loading

LLLLimbo Apr 9, 2021 •

edited

Loading