Modify the pubsub example to have custom span.#538
Merged
Conversation
mukundansundar
approved these changes
Apr 30, 2021
mukundansundar
suggested changes
Apr 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
============================================
+ Coverage 80.52% 80.65% +0.13%
- Complexity 981 982 +1
============================================
Files 88 88
Lines 3024 3024
Branches 331 331
============================================
+ Hits 2435 2439 +4
+ Misses 423 420 -3
+ Partials 166 165 -1
Continue to review full report at Codecov.
|
halspang
reviewed
Apr 30, 2021
halspang
left a comment
halspang
left a comment
Contributor
There was a problem hiding this comment.
Seems like the examples are failing to build while they're fine on master. Not sure how this change could've broken them but is that something we should check out?
Contributor
Author
|
I will take a look. |
Contributor
Author
For some reason, it was doing findbug checks on examples. Which did not do after I reran it. Locally, I had the same experience but it worked after I did a mvn clean. |
mukundansundar
approved these changes
May 3, 2021
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tracing example to PubSub.
Included command validation.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #537
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: