Issue 531#540
Closed
LLLLimbo wants to merge 8 commits into
Closed
Conversation
Add spring-boot-dependencies dependency management in sdk-springboot. Add maven-compiler-plugin to the parent pom's pluginManagement Remove protoc-jar-maven-plugin in example's dependencies.
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
============================================
+ Coverage 80.52% 80.65% +0.13%
- Complexity 981 982 +1
============================================
Files 88 88
Lines 3024 3024
Branches 331 331
============================================
+ Hits 2435 2439 +4
+ Misses 423 420 -3
+ Partials 166 165 -1
Continue to review full report at Codecov.
|
Contributor
|
Thanks for this. I will look at this post v1.1 release since we don't want to risk breaking the CI pipeline on the code freeze date. |
Contributor
|
Please, resolve conflicts. We can add this in this milestone. |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
see #531
Add plugins back in parent pom.
Issue reference
#531
Please reference the issue this PR will close: #[issue number]
Checklist