Skip to content

Remove no Longer Needed External Maven Repositories From README#557

Merged
artursouza merged 3 commits into
dapr:masterfrom
delvh:master
Jun 7, 2021
Merged

Remove no Longer Needed External Maven Repositories From README#557
artursouza merged 3 commits into
dapr:masterfrom
delvh:master

Conversation

@delvh

@delvh delvh commented May 28, 2021

Copy link
Copy Markdown
Contributor

Description

The Dapr Java SDK no longer needs external repositories to be downloaded using Maven or Gradle.
They have been removed from the README.

Issue reference

Fixes #550

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Comment thread README.md
@ghost

ghost commented Jun 3, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@artursouza

Copy link
Copy Markdown
Contributor

@delvh Thanks for your contribution. We cannot accept the change without the CLA being accepted.

@codecov

codecov Bot commented Jun 3, 2021

Copy link
Copy Markdown

Codecov Report

Merging #557 (ae9dcef) into master (9ce75d9) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #557      +/-   ##
============================================
+ Coverage     80.52%   80.65%   +0.13%     
- Complexity      981      982       +1     
============================================
  Files            88       88              
  Lines          3024     3024              
  Branches        331      331              
============================================
+ Hits           2435     2439       +4     
+ Misses          423      420       -3     
+ Partials        166      165       -1     
Impacted Files Coverage Δ
sdk/src/main/java/io/dapr/utils/Retry.java 75.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce75d9...ae9dcef. Read the comment docs.

@delvh

delvh commented Jun 3, 2021

Copy link
Copy Markdown
Contributor Author

@artursouza I think you can merge now.

@artursouza artursouza merged commit d056d9a into dapr:master Jun 7, 2021
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
…#557)

* Remove no longer needed external maven repositories

* Update README.md

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External repositories not needed anymore in README

2 participants