Skip to content

Enable dependabot for all packages.#570

Merged
artursouza merged 2 commits into
dapr:masterfrom
berndverst:master
Jul 3, 2021
Merged

Enable dependabot for all packages.#570
artursouza merged 2 commits into
dapr:masterfrom
berndverst:master

Conversation

@berndverst

Copy link
Copy Markdown
Member

Description

Replaces stale PR #499 to enable Dependabot.

@berndverst

Copy link
Copy Markdown
Member Author

Please take a look: @mukundansundar @halspang @artursouza

halspang
halspang previously approved these changes Jun 29, 2021

@halspang halspang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm curious to see how often things will actually update after the first set.

@codecov

codecov Bot commented Jun 29, 2021

Copy link
Copy Markdown

Codecov Report

Merging #570 (1a8f7b3) into master (0e5e311) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #570      +/-   ##
============================================
- Coverage     80.75%   80.61%   -0.14%     
+ Complexity      986      985       -1     
============================================
  Files            88       88              
  Lines          3039     3039              
  Branches        332      332              
============================================
- Hits           2454     2450       -4     
- Misses          419      422       +3     
- Partials        166      167       +1     
Impacted Files Coverage Δ
sdk/src/main/java/io/dapr/utils/Retry.java 50.00% <0.00%> (-25.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e5e311...1a8f7b3. Read the comment docs.

@berndverst

Copy link
Copy Markdown
Member Author

@halspang apparently I need to pause this PR at the moment to update this for the requirements in #348:

@mukundansundar @artursouza

It seems we want:

  • Dependabot making PRs into the dependabot branch (to be created)
  • Tests to run in the dependabot branch and upon success to create a PR against the master branch.

The problem I see here is...
Doesn't this mean the dependabot branch needs to be synced against master regularly?

@halspang

Copy link
Copy Markdown
Contributor

The problem I see here is...
Doesn't this mean the dependabot branch needs to be synced against master regularly?

Yes, but that could also be part of a workflow. Just merge master into it at some regular cadence. Or even as part of the workflow it could create, PR, merge, and then delete its own branch so it's fresh every time. That's what I'd go for personally but I think that relies on us being able to trigger dependabot instead of it going on its own cadence.

@artursouza artursouza merged commit 527d6c6 into dapr:master Jul 3, 2021
@artursouza artursouza mentioned this pull request Jul 3, 2021
3 tasks
@berndverst

Copy link
Copy Markdown
Member Author

Given that this PR was merged we will need to be careful not to approve every PR dependabot creates. This PR was never updated to use the special branch concept. However, doing so would also be unnecessarily complex and also error prone.

fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* Enable dependabot for all packages.

* Make dependabot PRs against special branch

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants