Skip to content

Add support for configuring actor reminder storage partitions#574

Merged
artursouza merged 7 commits into
dapr:masterfrom
berndverst:reminderPartitions
Jul 12, 2021
Merged

Add support for configuring actor reminder storage partitions#574
artursouza merged 7 commits into
dapr:masterfrom
berndverst:reminderPartitions

Conversation

@berndverst

Copy link
Copy Markdown
Member

Description

Add support for configuring actor reminder storage partitions

Issue reference

dapr/dapr#2889

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@berndverst

Copy link
Copy Markdown
Member Author

Codecov is wrong. Nothing changed here that would eliminate the use of sdk/src/main/java/io/dapr/utils/Retry.java or lower test coverage.

@berndverst berndverst marked this pull request as ready for review July 8, 2021 17:18
@berndverst berndverst requested review from a team as code owners July 8, 2021 17:18
@berndverst

Copy link
Copy Markdown
Member Author

Sorry about the unnecessary reformatting of some code. VSCode did that.

@artursouza

Copy link
Copy Markdown
Contributor

Let's wait until the runtime PR is merged before merging this. Thanks, @berndverst

@codecov

codecov Bot commented Jul 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #574 (3c923c2) into master (fdbd084) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #574      +/-   ##
============================================
+ Coverage     80.61%   80.65%   +0.03%     
- Complexity      985      988       +3     
============================================
  Files            88       88              
  Lines          3039     3044       +5     
  Branches        332      333       +1     
============================================
+ Hits           2450     2455       +5     
  Misses          422      422              
  Partials        167      167              
Impacted Files Coverage Δ
.../io/dapr/actors/runtime/ActorObjectSerializer.java 84.70% <100.00%> (+0.36%) ⬆️
...ava/io/dapr/actors/runtime/ActorRuntimeConfig.java 91.30% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbd084...3c923c2. Read the comment docs.

@berndverst

berndverst commented Jul 12, 2021

Copy link
Copy Markdown
Member Author

@artursouza runtime is merged. Do you want to merge this now? EDIT: Ah, you just did and CI/CD is running :)

@artursouza artursouza merged commit 48b2d44 into dapr:master Jul 12, 2021
@artursouza artursouza added this to the v1.2 milestone Jul 14, 2021
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* Update GRPC libraries for security updates

* AdConfigurable actor reminder storage patitions

* autoformat code

* Fix test and linter error

* more autoformatting

* competing style checker :(

Co-authored-by: Ubuntu <beverst@beverst-ubuntu.4gvshbv0hrpejbsei5kugsxnoc.xx.internal.cloudapp.net>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants