Skip to content

chore: format some places to make the code more standardized#578

Merged
artursouza merged 3 commits into
dapr:masterfrom
kevinten10:master
Jul 21, 2021
Merged

chore: format some places to make the code more standardized#578
artursouza merged 3 commits into
dapr:masterfrom
kevinten10:master

Conversation

@kevinten10

@kevinten10 kevinten10 commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

Hello Dapr team.

I'm now reading the source code of dapr-java-sdk.

I found some minor grammatical problems. So I submit this PR to standardize these.

I think this will leave a better first impression on more readers.

Wish dapr better! Thank you!

Description

format some places to make the code more standardized.

such as:

  1. add @Override
  2. remove extra blank lines
  3. remove useless import

Issue reference

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

RELEASE NOTE: N/A

@kevinten10 kevinten10 requested review from a team as code owners July 15, 2021 11:27
@ghost

ghost commented Jul 15, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@JsonIgnore
public Map<String, String> getStateOptionsAsMap() {
Map<String, String> mapOptions = null;
if (this != null) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, nice catch! This was probably an outcome of some refactoring, I guess.

@artursouza artursouza self-assigned this Jul 19, 2021
artursouza
artursouza previously approved these changes Jul 19, 2021

@artursouza artursouza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK to accept this change

@kevinten10

Copy link
Copy Markdown
Contributor Author

@artursouza I have finished the work, please approve it for me, thanks.

@codecov

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #578 (61dc2af) into master (94448a9) will increase coverage by 0.25%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #578      +/-   ##
============================================
+ Coverage     80.65%   80.90%   +0.25%     
- Complexity      988      990       +2     
============================================
  Files            88       88              
  Lines          3044     3042       -2     
  Branches        333      332       -1     
============================================
+ Hits           2455     2461       +6     
+ Misses          422      412      -10     
- Partials        167      169       +2     
Impacted Files Coverage Δ
...c/main/java/io/dapr/client/AbstractDaprClient.java 91.66% <ø> (ø)
...rc/main/java/io/dapr/client/DaprClientBuilder.java 68.42% <ø> (ø)
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 89.84% <ø> (ø)
...k/src/main/java/io/dapr/client/DaprClientHttp.java 91.89% <ø> (ø)
...rc/main/java/io/dapr/client/domain/CloudEvent.java 65.51% <ø> (ø)
...main/java/io/dapr/client/domain/HttpExtension.java 93.54% <ø> (ø)
.../main/java/io/dapr/client/domain/StateOptions.java 54.54% <60.00%> (+15.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94448a9...61dc2af. Read the comment docs.

@artursouza artursouza merged commit 50f80d8 into dapr:master Jul 21, 2021
@artursouza artursouza added this to the v1.3 milestone Jul 21, 2021
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
* chore: format some places to make the code more standardized

* test: add unit test for {@code DaprClient#getState} to cover {@code StateOptions#getStateOptionsAsMap}

Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants