Split build and publish steps in pipeline.#644
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=========================================
Coverage 77.25% 77.25%
Complexity 946 946
=========================================
Files 88 88
Lines 3012 3012
Branches 334 334
=========================================
Hits 2327 2327
Misses 523 523
Partials 162 162 Continue to review full report at Codecov.
|
halspang
reviewed
Oct 14, 2021
| runs-on: ubuntu-latest | ||
| needs: build | ||
| env: | ||
| JDK_VER: 11 |
Contributor
There was a problem hiding this comment.
The previous set of steps is run off the JDK matrix right? Do we care/need to duplicate that here?
Contributor
Author
There was a problem hiding this comment.
The intent is to avoid that. We only publish once.
halspang
approved these changes
Oct 14, 2021
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* Split build and publish steps in pipeline. * Update build.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee
pushed a commit
to fackee/java-sdk
that referenced
this pull request
Mar 28, 2022
* Split build and publish steps in pipeline. * Update build.yml Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
artursouza
added a commit
to pkedy/java-sdk
that referenced
this pull request
Jun 22, 2022
* Split build and publish steps in pipeline. * Update build.yml Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is important to make sure (1) the tests pass in all versions before publishing and (2) publishing only happens once.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: