Config api support by pravinpushkar · Pull Request #670 · dapr/java-sdk

pravinpushkar · 2021-12-29T13:02:11Z

Description

Adding support for preview configuration api's.
Added a new interface DaprPreviewClient for Preview Apis.

Issue reference

Add support for Configuration API #659

Checklist

Code compiles correctly
Created/updated tests
Extended the documentation

mukundansundar

I do not believe a new DaprPreviewClientProxy is needed ... that was added to make sure that by default the method invocation protocol is http ... That is not a scenario handled by the DaprPreviewClient interface at all ...
//cc @artursouza

mukundansundar · 2022-01-07T08:47:12Z

Please modify this workflow https://github.com/dapr/java-sdk/blob/master/.github/workflows/validate.yml

mukundansundar · 2022-01-07T11:05:53Z

@pravinpushkar the validations seem to be failing and failing improperly can you take a look at that?

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

mukundansundar

overall lgtm ... just some small tweaks.
Please add the JavaDoc comments at the class level alone ... similar to other domain classes.

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

codecov · 2022-01-12T23:19:21Z

Codecov Report

Merging #670 (4a916f7) into master (d8b8a5b) will increase coverage by 0.23%.
The diff coverage is 83.62%.

@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
+ Coverage     77.25%   77.49%   +0.23%     
- Complexity      946      990      +44     
============================================
  Files            88       91       +3     
  Lines          3012     3128     +116     
  Branches        334      342       +8     
============================================
+ Hits           2327     2424      +97     
- Misses          523      535      +12     
- Partials        162      169       +7

Impacted Files	Coverage Δ
...rc/main/java/io/dapr/client/DaprClientBuilder.java	`66.66% <0.00%> (-1.76%)`	⬇️
...rc/main/java/io/dapr/exceptions/DaprException.java	`70.37% <40.00%> (-3.10%)`	⬇️
.../java/io/dapr/client/domain/ConfigurationItem.java	`56.25% <56.25%> (ø)`
...io/dapr/client/domain/GetConfigurationRequest.java	`77.77% <77.77%> (ø)`
...r/client/domain/SubscribeConfigurationRequest.java	`77.77% <77.77%> (ø)`
...k/src/main/java/io/dapr/client/DaprClientGrpc.java	`90.76% <92.59%> (+0.30%)`	⬆️
...c/main/java/io/dapr/client/AbstractDaprClient.java	`92.77% <100.00%> (+2.29%)`	⬆️
...k/src/main/java/io/dapr/client/DaprClientHttp.java	`91.94% <100.00%> (+0.05%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b8a5b...4a916f7. Read the comment docs.

* inital draft for config api Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Introducing new client for preview apis and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Unit tests and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Adding integration test Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Copyright changes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Review comments fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Removed DaprPreviewClientProxy and updated example README Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Adding validate workflow for cofiguration api example Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * fixing example autovalidation and code coverage Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing autovalidation and removing getAllConfiguration Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing review comments Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Add regex header checkstyle. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix headers and add javadocs to some. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com>

* inital draft for config api Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Introducing new client for preview apis and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Unit tests and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Adding integration test Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Copyright changes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Review comments fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Removed DaprPreviewClientProxy and updated example README Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Adding validate workflow for cofiguration api example Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * fixing example autovalidation and code coverage Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing autovalidation and removing getAllConfiguration Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing review comments Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Add regex header checkstyle. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix headers and add javadocs to some. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com>

* inital draft for config api Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Introducing new client for preview apis and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Unit tests and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Adding integration test Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Copyright changes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Review comments fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Removed DaprPreviewClientProxy and updated example README Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Adding validate workflow for cofiguration api example Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * fixing example autovalidation and code coverage Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing autovalidation and removing getAllConfiguration Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing review comments Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Add regex header checkstyle. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix headers and add javadocs to some. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* inital draft for config api Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Introducing new client for preview apis and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Unit tests and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Adding integration test Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Copyright changes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Review comments fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Removed DaprPreviewClientProxy and updated example README Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Adding validate workflow for cofiguration api example Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * fixing example autovalidation and code coverage Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing autovalidation and removing getAllConfiguration Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing review comments Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Add regex header checkstyle. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix headers and add javadocs to some. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

…IPv6 environments (#649) * Generate updated javadocs for 1.3.1 (#643) Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Migrated out of JCenter as a Maven repository manager (#648) * Upgrade okhttp-mock dependency Version 1.3.2 was never deployed to Maven Central * No longer refer to JCenter, as it has been shut down Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * initial commit: modified ./dapr/client/DaprClientHttpTest.java unit test Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * refactored hardcoded 127.0.0.1 localhost IP to use Dapr sidecar IP Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * refactored hardcoded 127.0.0.1 localhost IP to use Dapr sidecar IP Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * cleaned up unused imports Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * fixed tabbing and imports Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * added utils for getting local host and test utils for ipv6 addresses Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Add auto-assign dapr_bot workflow (#654) Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Bump actions/setup-java from 2.3.1 to 2.4.0 (#663) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * added HTTP client tests for IPv6 addresses Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * fixed tests by returning SIDECAR_IP to IPv4 address Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * changes to address PMD code validation violations Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * changing back to loopback address for DEFAULT_SIDECAR_IP fallback Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Fix vault example + Upgrade Dapr CLI and runtime. (#666) * Upgrade Dapr CLI and runtime. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix expected vault output. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Update LICENSE to Apache 2.0 (#657) * Update LICENSE to Apache 2.0 Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Update headers to Apache 2. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Bump actions/github-script from 1 to 5 (#655) Bumps [actions/github-script](https://github.com/actions/github-script) from 1 to 5. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v1...v5) --- updated-dependencies: - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Add DCO requirements and updated code of conduct (#669) Issue reference: dapr/docs#2039 Signed-off-by: Will <william.wl.tsai@gmail.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Bump actions/setup-java from 2.4.0 to 2.5.0 (#668) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Config api support (#670) * inital draft for config api Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Introducing new client for preview apis and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Unit tests and code refactoring Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com> * Adding integration test Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Copyright changes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Review comments fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Removed DaprPreviewClientProxy and updated example README Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Adding validate workflow for cofiguration api example Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * fixing example autovalidation and code coverage Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing autovalidation and removing getAllConfiguration Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Fixing review comments Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * Add regex header checkstyle. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Fix headers and add javadocs to some. Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Update for next release: 1.5.0 snapshot (#672) * Update CLI and runtime to 1.6.0-rc.x Signed-off-by: Artur Souza <artursouza.ms@outlook.com> * Upgrade the version to 1.5.0-SNAPSHOT Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Update proto RC. (#674) Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Java SDK - Documentation for configuration API methods (#676) * Java SDK - Documentation for configuration API methods Signed-off-by: pravinpushkar <ppushkar@microsoft.com> * review comment fixes Signed-off-by: pravinpushkar <ppushkar@microsoft.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * Generate updated javadocs for 1.4.0 (#677) Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * address package dependency issue on integration test Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * added comment to include spec for ipv6 represention in url Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * corrected comment in NetworkUtils.getHostLoopbackAddress() Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * added comment to include spec for ipv6 represention in url Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * updated dependency scope to test Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> * fix NetworkUtils.java Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * checkstyle fix in NetworkUtils.java Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * fix imports Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * fix ipv6 formatting issues Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * fix ipv6 formatting issues Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * fix code style nits Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> * refactor formatIpAddress method in actors utls Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> --------- Signed-off-by: Will Tsai <william.wl.tsai@gmail.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Will <william.wl.tsai@gmail.com> Signed-off-by: Will <28876888+willtsai@users.noreply.github.com> Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Co-authored-by: Maarten Mulders <mthmulders@users.noreply.github.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com> Co-authored-by: Pravin Pushkar <ppushkar@microsoft.com> Co-authored-by: Cassie Coyle <cassie@diagrid.io>

pravinpushkar requested review from a team as code owners December 29, 2021 13:02

pravinpushkar force-pushed the config_api branch 2 times, most recently from d37fa44 to 550c29f Compare December 31, 2021 18:13

mukundansundar reviewed Jan 3, 2022

View reviewed changes

pravinpushkar force-pushed the config_api branch from 0cab852 to b8c9e0b Compare January 6, 2022 14:15

mukundansundar reviewed Jan 7, 2022

View reviewed changes

Comment thread examples/src/main/java/io/dapr/examples/configuration/grpc/README.md

pravinpushkar force-pushed the config_api branch from 8c84478 to dfe7189 Compare January 9, 2022 04:51

artursouza suggested changes Jan 12, 2022

View reviewed changes

pravinpushkar force-pushed the config_api branch from 35da5b2 to f45f5a2 Compare January 12, 2022 16:48

pravinpushkar added 11 commits January 12, 2022 22:30

inital draft for config api

8f5288b

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Introducing new client for preview apis and code refactoring

d9ac5c0

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Unit tests and code refactoring

8d52bcb

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Adding integration test

c28105f

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Copyright changes

276debc

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Review comments fixes

2035de9

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Removed DaprPreviewClientProxy and updated example README

3be1576

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Adding validate workflow for cofiguration api example

97d4fa0

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

fixing example autovalidation and code coverage

b837bc8

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Fixing autovalidation and removing getAllConfiguration

660744d

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

Fixing review comments

6e8a4ec

Signed-off-by: pravinpushkar <ppushkar@microsoft.com>

pravinpushkar force-pushed the config_api branch from f45f5a2 to 6e8a4ec Compare January 12, 2022 17:01

mukundansundar reviewed Jan 12, 2022

View reviewed changes

Comment thread sdk/src/main/java/io/dapr/client/domain/ConfigurationItem.java

Comment thread sdk/src/main/java/io/dapr/client/domain/SubscribeConfigurationRequest.java

artursouza added 2 commits January 12, 2022 14:55

Add regex header checkstyle.

b353a16

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Fix headers and add javadocs to some.

4a916f7

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

artursouza approved these changes Jan 12, 2022

View reviewed changes

artursouza added the auto-merge label Jan 12, 2022

dapr-bot merged commit 185cdba into dapr:master Jan 13, 2022

pravinpushkar mentioned this pull request Feb 2, 2022

REQUEST: New membership for @pravinpushkar dapr/community#140

Closed

4 tasks

Uh oh!

Conversation

pravinpushkar commented Dec 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukundansundar commented Jan 7, 2022

Uh oh!

mukundansundar commented Jan 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 12, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pravinpushkar commented Dec 29, 2021 •

edited

Loading