Skip to content

fix github action for dapr comment analyzer bot#680

Merged
dapr-bot merged 2 commits into
dapr:masterfrom
mukundansundar:fix-github-action
Jan 27, 2022
Merged

fix github action for dapr comment analyzer bot#680
dapr-bot merged 2 commits into
dapr:masterfrom
mukundansundar:fix-github-action

Conversation

@mukundansundar

Copy link
Copy Markdown
Contributor

Signed-off-by: Mukundan Sundararajan msundar.ms@outlook.com

Description

Fixing the Github comment analyser Dapr bot workflow. Currently it is failing because with v5 for the GitHub script action, there has been a breaking change - https://github.com/actions/github-script#breaking-changes-in-v5

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>
@mukundansundar mukundansundar requested review from a team as code owners January 26, 2022 09:40
@artursouza artursouza added this to the v1.5 milestone Jan 27, 2022
@codecov

codecov Bot commented Jan 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #680 (32aa8aa) into master (3e5fe39) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #680      +/-   ##
============================================
+ Coverage     77.49%   77.62%   +0.12%     
- Complexity      990      993       +3     
============================================
  Files            91       91              
  Lines          3128     3128              
  Branches        342      342              
============================================
+ Hits           2424     2428       +4     
+ Misses          535      534       -1     
+ Partials        169      166       -3     
Impacted Files Coverage Δ
...java/io/dapr/client/domain/DeleteStateRequest.java 100.00% <ø> (ø)
.../client/domain/ExecuteStateTransactionRequest.java 100.00% <ø> (ø)
...va/io/dapr/client/domain/GetBulkSecretRequest.java 100.00% <ø> (ø)
...ava/io/dapr/client/domain/GetBulkStateRequest.java 94.11% <ø> (ø)
...io/dapr/client/domain/GetConfigurationRequest.java 88.88% <ø> (+11.11%) ⬆️
...n/java/io/dapr/client/domain/GetSecretRequest.java 100.00% <ø> (ø)
...in/java/io/dapr/client/domain/GetStateRequest.java 100.00% <ø> (ø)
...va/io/dapr/client/domain/InvokeBindingRequest.java 100.00% <ø> (ø)
...ava/io/dapr/client/domain/InvokeMethodRequest.java 100.00% <ø> (ø)
...n/java/io/dapr/client/domain/SaveStateRequest.java 100.00% <ø> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9989832...32aa8aa. Read the comment docs.

@dapr-bot dapr-bot merged commit 4c077e1 into dapr:master Jan 27, 2022
fackee pushed a commit to fackee/java-sdk that referenced this pull request Feb 7, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 17, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
subash89 pushed a commit to subash89/java-sdk that referenced this pull request Mar 18, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Subash Gamage <subash.hewawidanagamage@fmr.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
fackee pushed a commit to fackee/java-sdk that referenced this pull request Mar 28, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>
artursouza added a commit to pkedy/java-sdk that referenced this pull request Jun 22, 2022
Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants