Query State Preview API implementation. by mukundansundar · Pull Request #697 · dapr/java-sdk

mukundansundar · 2022-02-28T10:05:29Z

Signed-off-by: Mukundan Sundararajan msundar.ms@outlook.com

Description

changes made for query state API.

The dependency updates are needed for Java SDK to successfully compile using Rosetta.

Have used MongoDb for querying stored state.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #653
closes #685
closes #702

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar · 2022-03-14T09:28:42Z

+      String[] methodSegments = method.split("/");
+
+      List<String> pathSegments = new ArrayList<>(Arrays.asList(DaprHttp.API_VERSION, "invoke", appId, "method"));
+      pathSegments.addAll(Arrays.asList(methodSegments));


@artursouza This change is because of the change dapr/dapr#4008

The PubsubIT was failing because the method name was messages/ttlTopic which was encoded as messages%2FttlTopic which worked before the previous change was made.

Let me know if we can do it in a different way. Related to #702

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar

@artursouza Is there any concern on updating the protobuf and protoc versions to these values ?

artursouza

I will look into the expression building next. This is an awesome PR! Thanks.

artursouza · 2022-03-15T18:06:14Z

+      String[] methodSegments = method.split("/");
+
+      List<String> pathSegments = new ArrayList<>(Arrays.asList(DaprHttp.API_VERSION, "invoke", appId, "method"));
+      pathSegments.addAll(Arrays.asList(methodSegments));


Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar · 2022-03-17T18:38:00Z

Numeric value is not returned properly from MongoDB

Based on that using ID as string for now. Will later change to Integer once the above issue is fixed.

codecov · 2022-03-21T04:03:10Z

Codecov Report

Merging #697 (499949d) into master (e3fa24f) will decrease coverage by 1.16%.
The diff coverage is 71.77%.

❗ Current head 499949d differs from pull request most recent head 8138a7e. Consider uploading reports for the commit 8138a7e to get more accurate results

@@             Coverage Diff              @@
##             master     #697      +/-   ##
============================================
- Coverage     80.72%   79.56%   -1.17%     
- Complexity      993     1092      +99     
============================================
  Files            81       92      +11     
  Lines          3020     3298     +278     
  Branches        340      376      +36     
============================================
+ Hits           2438     2624     +186     
- Misses          416      482      +66     
- Partials        166      192      +26

Impacted Files	Coverage Δ
.../src/main/java/io/dapr/client/DaprClientProxy.java	`75.86% <ø> (ø)`
sdk/src/main/java/io/dapr/client/DaprHttp.java	`92.24% <ø> (ø)`
.../io/dapr/client/domain/query/filters/InFilter.java	`31.57% <31.57%> (ø)`
...ain/java/io/dapr/client/domain/QueryStateItem.java	`40.00% <40.00%> (ø)`
...c/main/java/io/dapr/client/AbstractDaprClient.java	`88.17% <50.00%> (-4.60%)`	⬇️
.../io/dapr/client/domain/query/filters/EqFilter.java	`50.00% <50.00%> (ø)`
...java/io/dapr/client/domain/QueryStateResponse.java	`66.66% <66.66%> (ø)`
...va/io/dapr/client/domain/query/filters/Filter.java	`71.42% <71.42%> (ø)`
.../io/dapr/client/domain/query/filters/OrFilter.java	`76.47% <76.47%> (ø)`
...k/src/main/java/io/dapr/client/DaprClientHttp.java	`87.71% <76.74%> (-4.24%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fa24f...8138a7e. Read the comment docs.

* Query State Preview API implementation. Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Use latest dapr ref and fix grpc query state api Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * fix service invocation automatic unesacpe Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * add more unit tests Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Add query state API docs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Fix example to be user friendly Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Fix example in docs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * make pagination immutable Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: zjx244729 <zjx244729@alibaba-inc.com>

* Query State Preview API implementation. Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Use latest dapr ref and fix grpc query state api Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * fix service invocation automatic unesacpe Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * add more unit tests Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Add query state API docs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Fix example to be user friendly Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * Fix example in docs Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> * make pagination immutable Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com> Co-authored-by: Artur Souza <artursouza.ms@outlook.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

mukundansundar force-pushed the query_state_api branch 2 times, most recently from bf938df to 4ba1945 Compare February 28, 2022 13:57

Query State Preview API implementation.

6be47a8

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar force-pushed the query_state_api branch from 4ba1945 to 6be47a8 Compare February 28, 2022 14:02

mukundansundar and others added 3 commits March 14, 2022 13:10

Use latest dapr ref and fix grpc query state api

83304f0

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

fix service invocation automatic unesacpe

6dbaa5b

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Merge branch 'master' into query_state_api

89a7dbd

mukundansundar commented Mar 14, 2022

View reviewed changes

mukundansundar marked this pull request as ready for review March 14, 2022 09:52

mukundansundar requested review from a team as code owners March 14, 2022 09:52

add more unit tests

6060eb3

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar commented Mar 14, 2022

View reviewed changes

Comment thread sdk/src/main/java/io/dapr/client/domain/QueryStateRequest.java

mukundansundar commented Mar 14, 2022

View reviewed changes

Comment thread sdk/src/main/java/io/dapr/client/domain/QueryStateRequest.java

mukundansundar and others added 2 commits March 15, 2022 09:51

Merge branch 'master' into query_state_api

14f389b

Add query state API docs

d97d330

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

mukundansundar mentioned this pull request Mar 15, 2022

Add IntelliJ IT docs #705

Merged

3 tasks

Merge branch 'master' into query_state_api

793f9b1

mukundansundar commented Mar 15, 2022

View reviewed changes

Comment thread pom.xml

Comment thread examples/pom.xml

Comment thread examples/pom.xml

artursouza suggested changes Mar 15, 2022

View reviewed changes

mukundansundar and others added 5 commits March 15, 2022 23:56

Merge branch 'master' into query_state_api

d3c9253

Merge branch 'master' into query_state_api

e413bce

Fix example to be user friendly

b2d133d

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

Fix example in docs

0ea8d80

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

make pagination immutable

499949d

Signed-off-by: Mukundan Sundararajan <msundar.ms@outlook.com>

artursouza approved these changes Mar 17, 2022

View reviewed changes

Merge branch 'master' into query_state_api

8138a7e

artursouza merged commit 06d92da into dapr:master Mar 21, 2022

mukundansundar deleted the query_state_api branch April 7, 2022 01:38

Uh oh!

Conversation

mukundansundar commented Feb 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

mukundansundar Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artursouza Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mukundansundar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artursouza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artursouza Mar 15, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mukundansundar commented Mar 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 21, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mukundansundar commented Feb 28, 2022 •

edited

Loading

mukundansundar Mar 14, 2022 •

edited

Loading

mukundansundar commented Mar 17, 2022 •

edited

Loading