Test long vals by mukundansundar · Pull Request #717 · dapr/java-sdk

mukundansundar · 2022-03-29T06:50:48Z

Description

Fixing the long values Test ...

Ran it 4 times in Github, did not fail once.

Basically I believe the change was the TTL seconds to 30 instead of 1. We are not testing TTL in this test.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

mukundansundar · 2022-03-29T07:13:46Z

@tanvigour Please see this PR Draft ...

mukundansundar · 2022-03-29T17:01:36Z

closing this as a draft.

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

codecov · 2022-03-31T09:52:44Z

Codecov Report

Merging #717 (d826a39) into master (bfe7f38) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage     78.19%   78.19%           
  Complexity     1117     1117           
=========================================
  Files            97       97           
  Lines          3417     3417           
  Branches        399      399           
=========================================
  Hits           2672     2672           
  Misses          547      547           
  Partials        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe7f38...d826a39. Read the comment docs.

tanvigour

Were there issues related to previously low TTL seen?

mukundansundar · 2022-04-01T04:34:32Z

Were there issues related to previously low TTL seen?

flaky test

artursouza · 2022-04-01T04:36:01Z

Partially fixes #725

* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com>

* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* run IT test for long values Signed-off-by: tanvigour <tanvi.gour@gmail.com> * Fix the class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * assert for all messages and fix class name Signed-off-by: tanvigour <tanvi.gour@gmail.com> * test for Long.MAX_VALUE Signed-off-by: tanvigour <tanvi.gour@gmail.com> * revert back long number and print Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix the typo Signed-off-by: tanvigour <tanvi.gour@gmail.com> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <tanvi.gour@gmail.com> * log some more data to debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * debug Signed-off-by: tanvigour <tanvi.gour@gmail.com> * get the value from messages Signed-off-by: tanvigour <tanvi.gour@gmail.com> * fix long values assert Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> * increasing TTL Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com> Co-authored-by: tanvigour <tanvi.gour@gmail.com> Co-authored-by: tanvigour <60332928+tanvigour@users.noreply.github.com> Signed-off-by: naah69 <nayan3480232@163.com>

tanvigour and others added 13 commits March 23, 2022 09:18

run IT test for long values

c759e2d

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Fix the class name

afc31e6

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Merge branch 'master' into tanvi/test_longvalues

b913cf9

assert for all messages and fix class name

fa8f19d

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

Merge branch 'master' into tanvi/test_longvalues

52bcadc

test for Long.MAX_VALUE

a31516f

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

revert back long number and print

acd4a32

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

fix the typo

bf825b1

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

update the latest dapr commit in workflow files

ba29451

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

log some more data to debug

4ba4859

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

debug

93a5943

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

get the value from messages

09c52af

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

fix long values assert

7fe8c65

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

tanvigour previously approved these changes Mar 29, 2022

View reviewed changes

mukundansundar closed this Mar 29, 2022

mukundansundar deleted the test-long-vals branch March 29, 2022 17:01

mukundansundar restored the test-long-vals branch March 31, 2022 06:58

mukundansundar reopened this Mar 31, 2022

Merge branch 'master' into test-long-vals

e35738c

mukundansundar dismissed tanvigour’s stale review via e35738c March 31, 2022 07:02

increasing TTL

d826a39

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

mukundansundar marked this pull request as ready for review March 31, 2022 11:26

mukundansundar requested review from a team as code owners March 31, 2022 11:26

tanvigour reviewed Mar 31, 2022

View reviewed changes

artursouza approved these changes Apr 1, 2022

View reviewed changes

artursouza merged commit 78a7312 into dapr:master Apr 1, 2022

mukundansundar deleted the test-long-vals branch April 8, 2022 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Test long vals#717

Test long vals#717
artursouza merged 15 commits into
dapr:masterfrom
mukundansundar:test-long-vals

mukundansundar commented Mar 29, 2022 •

edited

Loading

Uh oh!

mukundansundar commented Mar 29, 2022

Uh oh!

mukundansundar commented Mar 29, 2022

Uh oh!

codecov Bot commented Mar 31, 2022

Uh oh!

tanvigour left a comment

Uh oh!

mukundansundar commented Apr 1, 2022

Uh oh!

artursouza commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mukundansundar commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

mukundansundar commented Mar 29, 2022

Uh oh!

mukundansundar commented Mar 29, 2022

Uh oh!

codecov Bot commented Mar 31, 2022

Codecov Report

Uh oh!

tanvigour left a comment

Choose a reason for hiding this comment

Uh oh!

mukundansundar commented Apr 1, 2022

Uh oh!

artursouza commented Apr 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mukundansundar commented Mar 29, 2022 •

edited

Loading