Skip to content

Added new version to README#35

Merged
kimf merged 5 commits intomasterfrom
updated-version
Sep 9, 2020
Merged

Added new version to README#35
kimf merged 5 commits intomasterfrom
updated-version

Conversation

@kimf
Copy link
Contributor

@kimf kimf commented Sep 8, 2020

Please give input here...

- Use data from provided API (see API DOCS)
- Good usability
- Be visually appealing and follow platform conventions
- Budget: 8-12 hours
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the budget part. But maybe we are communicating this in other ways?

Copy link

@kurtsson kurtsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Maybe suggesting creating a private fork? The previous work sample had so many public solutions that it was hard to know if they just copied someone elses. But now with unlimited private repos it might be feasible?

@mohamad-daresay
Copy link

👍 Maybe suggesting creating a private fork? The previous work sample had so many public solutions that it was hard to know if they just copied someone elses. But now with unlimited private repos it might be feasible?

How if we also ask for a commits log (avoiding squash), it can provide us a good vision of developer's thoughts and also preventing them from copying 🤔

Copy link

@mohamad-daresay mohamad-daresay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@likebobby
Copy link
Contributor

👍 Maybe suggesting creating a private fork? The previous work sample had so many public solutions that it was hard to know if they just copied someone elses. But now with unlimited private repos it might be feasible?

How if we also ask for a commits log (avoiding squash), it can provide us a good vision of developer's thoughts and also preventing them from copying 🤔

Yes, great idea. We can add a section of "A nice commit history describing your work is preferred over squashing it into one."

Copy link
Contributor

@likebobby likebobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me now.

@kimf kimf merged commit 99df8bb into master Sep 9, 2020
@kimf kimf deleted the updated-version branch September 9, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants