Add checkboxs to select planetType and delete the dangerous globalButton - #121
Closed
FlakesGG wants to merge 1 commit into
Closed
Add checkboxs to select planetType and delete the dangerous globalButton#121FlakesGG wants to merge 1 commit into
FlakesGG wants to merge 1 commit into
Conversation
Contributor
|
Don't delete the global button |
Contributor
|
This is also now out of date with the patterns introduced in #120 |
Contributor
|
We've merged some updates for this plugin in #124 so I'm going to close this. Would love to get the checkbox changes if you want to re-implement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone want to crawl only Asteroid and Spacetime Rip
or someone want to crawl all type besides Quasar.
And the globalButton to crawl all it too dangerous for many people, so maybe should delete it ?