Skip to content

Guess Steam mp4 trailer url if not found#707

Merged
darklinkpower merged 1 commit into
darklinkpower:emlCrashFix2025from
supersmo:fix/temp-fix-steam-trailer-on-demand
Dec 13, 2025
Merged

Guess Steam mp4 trailer url if not found#707
darklinkpower merged 1 commit into
darklinkpower:emlCrashFix2025from
supersmo:fix/temp-fix-steam-trailer-on-demand

Conversation

@supersmo
Copy link
Copy Markdown

@supersmo supersmo commented Dec 7, 2025

I have verified that:

  • These changes work, by building the extension and testing.
  • That the changes comply with the rules indicated in the repository.
  • Pull request is targeting master branch.

Pull request is not targeting the master branch since it is not the current working branch.
See: #706 (comment)

This changes the behavior for Steam trailer on demand streaming. Steam recently stopped returning the mp4 URL of trailers in the appdetails response.

  • If the mp4 url is available in the cached appdetails file then that is used.
  • Otherwise an attempt is made to guess the URL of the mp4.
  • A simple test is made to see if the URL is available and if it is then that is used to display the trailer.

This is a temporary solution. A more robust solution would be to get a video player to play the m3u8 or mpd urls of the trailers.

See: #705

@justin-delano
Copy link
Copy Markdown

can you provide a .pext for testing? I've run into the same issue!

@joyrider3774
Copy link
Copy Markdown

joyrider3774 commented Dec 12, 2025

i compiled and tried this, but when i right click on a game a choose to download video trailers it does not find any, however it does find the microtrailers it seems

edit:

it seems microtrailers could always be downloaded, i just patched a local version of mine to use yt-dlp.exe as well to download steam trailers based on youtube download and the dash h264 url and that seems to work fine but a lot slower for downloading the trailers

also my comment above is bogus steam micro trailers always still downloaded.

@supersmo it seems your branch is only adding guesses for streaming the videos but not for downloading them. the location where it downloads things is here https://github.com/darklinkpower/PlayniteExtensionsCollection/blob/emlCrashFix2025/source/Generic/ExtraMetadataLoader/Services/VideosDownloader.cs#L85C15-L85C30

@supersmo
Copy link
Copy Markdown
Author

@justin-delano I've now published a .pext file here: https://github.com/supersmo/PlayniteExtensionsCollection/releases/tag/v1.82.1

@joyrider3774 True, I have never used the video download feature so I only looked into fixing the streaming part. I will try to find the time to look into it this weekend.

@justin-delano
Copy link
Copy Markdown

@supersmo thank you so much, this worked for me!

@darklinkpower darklinkpower merged commit e98a99b into darklinkpower:emlCrashFix2025 Dec 13, 2025
@darklinkpower
Copy link
Copy Markdown
Owner

Merged, thanks a lot for the contribution

@supersmo supersmo deleted the fix/temp-fix-steam-trailer-on-demand branch December 13, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants