Tighten public API + cleanup #39
Merged
TedSander merged 4 commits intodart-lang:masterfrom Oct 4, 2016
Merged
Conversation
Contributor
Author
|
Removing these from the public API is a breaking change, so we should bump the major version. I checked and there are no references at all to these internally in Google. Going forward we should be more careful with what's exposed. WDYT @TedSander ? |
Contributor
|
I think this looks good, but yes please bump the major version as it does have breaking changes. |
Contributor
|
Please rebase. Matan just added matcher functionality that clients can use. |
Contributor
|
+1. Thanks. |
srawlins
reviewed
Oct 3, 2016
lib/src/mock.dart
Outdated
| typedef dynamic Answering(Invocation realInvocation); | ||
|
|
||
| typedef VerificationResult Verification(matchingInvocations); | ||
| typedef VerificationResult _Verification(matchingInvocations); |
Member
There was a problem hiding this comment.
I think this has to stay public, yes?
Verification verification = verify(foo.bar(captureAny));
var args = verification.captured;
verification.called(1);
Contributor
Author
|
PTAL @srawlins |
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Oct 17, 2024
Tighten public API + cleanup
davidmorgan
pushed a commit
to dart-lang/build
that referenced
this pull request
Mar 23, 2026
Tighten public API + cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly expose public methods in order not to leak internals and re-expose
mockito_no_mirrors.dartfrommockito.dartto ensure consistency.Removes
CannedResponse,InOrderVerification,Verification,RealCall,resetMockitoStatefrom the public API since these are only meant to be used internally by Mockito.toStringlogic inRealCall,verifyInOrdertake aListsince taking a single argument would be an invalid usage,dartfmt