Make the LCP internal error printout less aggressive#1238
Merged
jslee02 merged 3 commits intorelease-6.8from Feb 13, 2019
Merged
Make the LCP internal error printout less aggressive#1238jslee02 merged 3 commits intorelease-6.8from
jslee02 merged 3 commits intorelease-6.8from
Conversation
jslee02
approved these changes
Feb 13, 2019
Member
There was a problem hiding this comment.
Theoretically, the "s" value should always be positive. It's undefined behavior otherwise. However, it seems the tiny values are negligible.
For the case of s <= 0, we may want to fall back to using an iterative constraint solver, which is less accurate but more robust, once it's available. But let's stick to Dantzig until then.
Member
Author
|
It wouldn't surprise me if these tiny "failures" boil down to floating point precision issues. |
Collaborator
|
Another approach is calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A line in the LCP solver may print out excessive warnings over minor imprecision. This causes unnecessary terminal spam that looks like this:
These messages often print even when nothing is really wrong with the simulation. I've wrapped the printout of this message in an if-statement that should make the LCP solver less aggressive when it comes to printing this out.
Before merging a pull request
CHANGELOG.md