Remove warning of ImGuiViewer + OSG shadow#1312
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 57.18% 57.19% +0.01%
==========================================
Files 366 366
Lines 27023 27023
==========================================
+ Hits 15452 15457 +5
+ Misses 11571 11566 -5
|
mxgrey
approved these changes
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The incompatibility issue of ImGuiViewer + OSG shadow found in #978 was fixed in #1274. Particularly, these two blocks (1, 2) resolved the issue.
Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md