Skip to content

Deprecate custom make_unique in favor of std::make_unique#1317

Merged
jslee02 merged 4 commits intomasterfrom
remove_make_unique
May 16, 2019
Merged

Deprecate custom make_unique in favor of std::make_unique#1317
jslee02 merged 4 commits intomasterfrom
remove_make_unique

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented May 16, 2019

As we migrated to C++14, the custom make_unique is deprecated in favor of std::make_unique.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 16, 2019
@jslee02 jslee02 marked this pull request as ready for review May 16, 2019 05:25
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #1317 into master will decrease coverage by <.01%.
The diff coverage is 55.31%.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   57.13%   57.13%   -0.01%     
==========================================
  Files         366      366              
  Lines       27052    27050       -2     
==========================================
- Hits        15457    15455       -2     
  Misses      11595    11595
Impacted Files Coverage Δ
dart/dynamics/ReferentialSkeleton.cpp 40.66% <ø> (ø) ⬆️
dart/common/detail/Factory-impl.hpp 100% <ø> (ø) ⬆️
dart/common/detail/Memory-impl.hpp 100% <ø> (ø) ⬆️
dart/dynamics/SharedLibraryIkFast.cpp 51.13% <0%> (ø) ⬆️
dart/common/AspectWithVersion.hpp 42.85% <0%> (ø) ⬆️
dart/dynamics/Skeleton.cpp 66.12% <0%> (ø) ⬆️
dart/common/detail/ProxyAspect.hpp 64.7% <0%> (ø) ⬆️
dart/dynamics/InverseKinematics.cpp 49.46% <0%> (ø) ⬆️
dart/dynamics/detail/CompositeNode.hpp 50% <100%> (ø) ⬆️
dart/common/EmbeddedAspect.hpp 95.34% <100%> (ø) ⬆️
... and 14 more

@jslee02 jslee02 merged commit 968013c into master May 16, 2019
@jslee02 jslee02 deleted the remove_make_unique branch May 16, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant