Skip to content

Fix compilation warnings with GCC 9.1#1366

Merged
jslee02 merged 3 commits intomasterfrom
gcc_9.1
Jul 8, 2019
Merged

Fix compilation warnings with GCC 9.1#1366
jslee02 merged 3 commits intomasterfrom
gcc_9.1

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Jul 7, 2019

  • Fix redundant use of std::move() in return statement
  • Obey the rule of three when the custom copy constructor is defined

Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jul 7, 2019
@jslee02 jslee02 requested a review from mxgrey July 7, 2019 16:40
@jslee02 jslee02 marked this pull request as ready for review July 7, 2019 16:47
@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #1366 into master will decrease coverage by 0.02%.
The diff coverage is 45.28%.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   56.92%   56.89%   -0.03%     
==========================================
  Files         366      366              
  Lines       27341    27387      +46     
==========================================
+ Hits        15563    15581      +18     
- Misses      11778    11806      +28
Impacted Files Coverage Δ
dart/dynamics/detail/PlanarJointAspect.hpp 100% <ø> (ø) ⬆️
dart/common/sub_ptr.hpp 100% <ø> (ø) ⬆️
...art/dynamics/detail/TranslationalJoint2DAspect.hpp 50% <ø> (-10%) ⬇️
dart/collision/bullet/BulletCollisionDetector.cpp 70.15% <0%> (ø) ⬆️
dart/dynamics/detail/GenericJointAspect.hpp 50% <0%> (-35.19%) ⬇️
dart/dynamics/detail/BodyNodePtr.hpp 93.67% <100%> (+0.24%) ⬆️
dart/dynamics/detail/PlanarJointAspect.cpp 86.88% <100%> (+3.21%) ⬆️
dart/utils/VskParser.cpp 72.13% <100%> (ø) ⬆️
dart/common/detail/sub_ptr.hpp 95.65% <100%> (+0.41%) ⬆️
...art/dynamics/detail/TranslationalJoint2DAspect.cpp 32.05% <50%> (+3.26%) ⬆️
... and 4 more

@jslee02 jslee02 merged commit 420241d into master Jul 8, 2019
@jslee02 jslee02 deleted the gcc_9.1 branch July 8, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant