Skip to content

Migrate from legacy setup.py to modern pyproject.toml#2043

Merged
jslee02 merged 1 commit intodartsim:mainfrom
jeongseok-meta:pyproject_migration
Oct 20, 2025
Merged

Migrate from legacy setup.py to modern pyproject.toml#2043
jslee02 merged 1 commit intodartsim:mainfrom
jeongseok-meta:pyproject_migration

Conversation

@jeongseok-meta
Copy link
Contributor

Removes setup.py entirely and migrates to a pure pyproject.toml build configuration using scikit-build-core as the build backend.

Before creating a pull request

  • Format code using pixi run lint and verify with pixi run check-lint
  • Document new methods and classes
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve warnings

Before merging

  • Set milestone
  • Update CHANGELOG.md
  • Add unit tests
  • Add Python bindings (dartpy) if applicable

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.90%. Comparing base (d8607b7) to head (3c2bf99).
⚠️ Report is 382 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2043   +/-   ##
=======================================
  Coverage   58.90%   58.90%           
=======================================
  Files         385      385           
  Lines       34578    34578           
  Branches     3883     3883           
=======================================
  Hits        20367    20367           
  Misses      14211    14211           
Flag Coverage Δ
unittests 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 marked this pull request as ready for review October 12, 2025 15:55
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@jslee02 jslee02 added this to the DART 7.0 milestone Oct 12, 2025
@jeongseok-meta
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jeongseok-meta jeongseok-meta force-pushed the pyproject_migration branch 2 times, most recently from 4885a6b to d99b7e4 Compare October 20, 2025 01:33
@jeongseok-meta
Copy link
Contributor Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jeongseok-meta
Copy link
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jslee02 jslee02 merged commit c5f6fc2 into dartsim:main Oct 20, 2025
11 checks passed
@jeongseok-meta jeongseok-meta deleted the pyproject_migration branch October 20, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants