Skip to content

Reorganize tests into logical subdirectories#2071

Merged
jslee02 merged 1 commit intodartsim:mainfrom
jeongseok-meta:test_reorg
Oct 26, 2025
Merged

Reorganize tests into logical subdirectories#2071
jslee02 merged 1 commit intodartsim:mainfrom
jeongseok-meta:test_reorg

Conversation

@jeongseok-meta
Copy link
Contributor

  • Group integration tests by category: collision, constraint, dynamics, io, optimization, simulation, utils
  • Organize unit tests: collision, constraint, dynamics, lcpsolver
  • Rename regression tests from Issue#### to descriptive names
  • Consolidate test helpers into tests/helpers/
  • Remove deprecated tests
  • Update CMake configuration

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Document new methods and classes
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve warnings

Before merging

  • Set milestone
  • Update CHANGELOG.md
  • Add unit tests
  • Add Python bindings (dartpy) if applicable

@jeongseok-meta jeongseok-meta marked this pull request as ready for review October 26, 2025 17:31
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- Group integration tests by category: collision, constraint, dynamics, io, optimization, simulation, utils
- Organize unit tests: collision, constraint, dynamics, lcpsolver
- Rename regression tests from Issue#### to descriptive names
- Consolidate test helpers into tests/helpers/
- Remove deprecated tests
- Update CMake configuration
@jslee02
Copy link
Member

jslee02 commented Oct 26, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 merged commit 698b15f into dartsim:main Oct 26, 2025
16 of 18 checks passed
@jeongseok-meta jeongseok-meta deleted the test_reorg branch October 26, 2025 18:41
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.47%. Comparing base (1e4ea46) to head (15b03b7).
⚠️ Report is 396 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   59.06%   58.47%   -0.59%     
==========================================
  Files         386      386              
  Lines       32475    32475              
  Branches     3969     3964       -5     
==========================================
- Hits        19182    18991     -191     
- Misses      13293    13484     +191     
Flag Coverage Δ
unittests 58.47% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants