[6.16] Fix pybind11 detection and assert includes#2118
Merged
jslee02 merged 10 commits intorelease-6.16from Nov 8, 2025
Merged
[6.16] Fix pybind11 detection and assert includes#2118jslee02 merged 10 commits intorelease-6.16from
jslee02 merged 10 commits intorelease-6.16from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-6.16 #2118 +/- ##
=============================================
Coverage 58.67% 58.67%
=============================================
Files 384 384
Lines 32059 32059
Branches 3870 3870
=============================================
Hits 18810 18810
Misses 13249 13249
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Werrorbuilds.<cassert>includes in the core/common codepaths so clang-format remains stable in CI, while usingDART_ASSERTthroughout the optimizer/common code instead of rawassert.Testing
pixi run test-allpixi run check-lint-cppBefore creating a pull request
pixi run lintand verify withpixi run check-lint-DDART_TREAT_WARNINGS_AS_ERRORS=ONand resolve warningsBefore merging
CHANGELOG.md