Skip to content

Remove deprecated DART_COMMON_MAKE_SHARED_WEAK#2127

Merged
jslee02 merged 1 commit intomainfrom
remove-pre64-deprecations
Nov 9, 2025
Merged

Remove deprecated DART_COMMON_MAKE_SHARED_WEAK#2127
jslee02 merged 1 commit intomainfrom
remove-pre64-deprecations

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 9, 2025

Prune the legacy smart-pointer macro deprecated in DART 6.4.

  • Delete DART_COMMON_MAKE_SHARED_WEAK so code uses DART_COMMON_DECLARE_SHARED_WEAK directly.
  • Update documentation and examples to reference the supported macro.
  • Note the removal in the DART 7 changelog.

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@jslee02 jslee02 enabled auto-merge (squash) November 9, 2025 04:55
@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.65%. Comparing base (f146767) to head (8f629d1).
⚠️ Report is 375 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2127   +/-   ##
=======================================
  Coverage   61.65%   61.65%           
=======================================
  Files         393      393           
  Lines       33195    33195           
  Branches     4095     4095           
=======================================
  Hits        20466    20466           
  Misses      12729    12729           
Flag Coverage Δ
unittests 61.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 merged commit 97fc228 into main Nov 9, 2025
37 checks passed
@jslee02 jslee02 deleted the remove-pre64-deprecations branch November 9, 2025 06:39
@jslee02 jslee02 added this to the DART 7.0 milestone Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant