Skip to content

Rename meta headers to All.hpp#2166

Merged
jslee02 merged 5 commits intomainfrom
rename-all-hpp
Nov 14, 2025
Merged

Rename meta headers to All.hpp#2166
jslee02 merged 5 commits intomainfrom
rename-all-hpp

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 13, 2025

Renames every auto-generated all.hpp legacy meta header (except dart8/dartpy8) to All.hpp so the public headers match the PascalCase convention used throughout the dart/ and python/dartpy/ trees. The CMake helper is updated to emit All.hpp, dart/All.hpp replaces the lowercase umbrella, and every include/doc reference now points to the new casing.

Validated with pixi run lint.


Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.95%. Comparing base (6d563bd) to head (06d6af9).
⚠️ Report is 354 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   61.95%   61.95%           
=======================================
  Files         393      393           
  Lines       33207    33207           
  Branches     4139     4139           
=======================================
  Hits        20572    20572           
  Misses      12635    12635           
Flag Coverage Δ
unittests 61.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/utils/VskParser.cpp 73.81% <ø> (ø)
dart/utils/mjcf/MjcfParser.cpp 82.35% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 13, 2025
@jslee02 jslee02 marked this pull request as ready for review November 13, 2025 20:28
@jslee02 jslee02 enabled auto-merge (squash) November 13, 2025 20:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 13, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 merged commit 664524d into main Nov 14, 2025
37 of 40 checks passed
@jslee02 jslee02 deleted the rename-all-hpp branch November 14, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant