Skip to content

Add distro build toggles#2177

Merged
jslee02 merged 1 commit intomainfrom
termux-build-options
Nov 15, 2025
Merged

Add distro build toggles#2177
jslee02 merged 1 commit intomainfrom
termux-build-options

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 15, 2025

  • Add DART_BUILD_TESTS, DART_BUILD_EXAMPLES, and DART_BUILD_TUTORIALS toggles so packagers can disable heavy targets and gate them on dart-gui-osg availability.
  • Propagate the knobs through pixi run workflows plus docs/changelog so CI and local builds stay consistent.
  • Fix the pkg-config Cflags export to report the installed include path for downstream consumers.

Tested with CMAKE_BUILD_PARALLEL_LEVEL=12 pixi run lint.


Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 15, 2025
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.27%. Comparing base (ad5a99f) to head (6715a63).
⚠️ Report is 346 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2177   +/-   ##
=======================================
  Coverage   62.26%   62.27%           
=======================================
  Files         393      393           
  Lines       33207    33207           
  Branches     4137     4138    +1     
=======================================
+ Hits        20676    20679    +3     
+ Misses      12531    12528    -3     
Flag Coverage Δ
unittests 62.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 marked this pull request as ready for review November 15, 2025 02:54
@jslee02
Copy link
Member Author

jslee02 commented Nov 15, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 merged commit d325d92 into main Nov 15, 2025
37 checks passed
@jslee02 jslee02 deleted the termux-build-options branch November 15, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant