Skip to content

Improve ShapeNode inertia coverage#2187

Merged
jslee02 merged 4 commits intomainfrom
feature/shape-node-inertia-coverage
Nov 16, 2025
Merged

Improve ShapeNode inertia coverage#2187
jslee02 merged 4 commits intomainfrom
feature/shape-node-inertia-coverage

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 16, 2025

Fixes #348.

Add regression coverage for the new ShapeNode inertia helpers so BodyNode aggregation and parser importers are tested end-to-end, plus document the brace style that protects these paths. Includes two fixtures to exercise both .skel and .vsk importers.

  • add unit tests for ShapeNode density conversion and invalid mass providers
  • add Skel/Vsk integration tests driven by new fixtures
  • update onboarding docs with the "always use braces" reminder

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 16, 2025
@jslee02
Copy link
Member Author

jslee02 commented Nov 16, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Delightful!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 16, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.69%. Comparing base (038cc73) to head (4630b41).
⚠️ Report is 332 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   63.65%   63.69%   +0.04%     
==========================================
  Files         394      394              
  Lines       33362    33362              
  Branches     4162     4163       +1     
==========================================
+ Hits        21235    21249      +14     
+ Misses      12127    12113      -14     
Flag Coverage Δ
unittests 63.69% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 enabled auto-merge (squash) November 16, 2025 17:04
@jslee02 jslee02 merged commit 683999d into main Nov 16, 2025
37 checks passed
@jslee02 jslee02 deleted the feature/shape-node-inertia-coverage branch November 16, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Most implementations of Shape::computeInertia do not account for their local transform

1 participant