Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2222 +/- ##
==========================================
+ Coverage 61.05% 61.10% +0.04%
==========================================
Files 353 353
Lines 32144 32228 +84
Branches 4183 4225 +42
==========================================
+ Hits 19627 19693 +66
- Misses 12517 12535 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3f63f98 to
d355cea
Compare
# Conflicts: # CHANGELOG.md # dart/constraint/CouplerConstraint.cpp # python/dartpy/dynamics/Joint.cpp # python/dartpy_docs/dynamics.py
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closes #1684.
API changes (with example)
Before (joint-wide mimic only):
After (per-DoF mimic configuration):
Coupler constraints now activate only when every DoF is mimic with a valid reference; mixed joints fall back to mimic motors.
Before creating a pull request
pixi run test-allto lint, build, and test your changes