Skip to content

Improve dart8 shared builds and CI stability#2228

Merged
jslee02 merged 4 commits intomainfrom
chore/pixi-install-consistency
Nov 21, 2025
Merged

Improve dart8 shared builds and CI stability#2228
jslee02 merged 4 commits intomainfrom
chore/pixi-install-consistency

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 21, 2025

  • honor BUILD_SHARED_LIBS for dart8 and ensure dart8 tests prepend the DLL path so shared builds work on Windows
  • guard serializer registration to avoid duplicate dart8 registrations
  • cap default build parallelism to avoid posix_spawn resource errors on Linux runners
  • avoid re-installing pixi on Windows when already present and skip the install step to keep jobs within limits

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes (relied on GitHub CI)
  • Add unit tests for new functionality (not applicable)
  • Document new methods and classes (not applicable)
  • Add Python bindings (dartpy) if applicable (not applicable)

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.26%. Comparing base (7fcbfc6) to head (feb20b6).
⚠️ Report is 289 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2228      +/-   ##
==========================================
- Coverage   61.27%   61.26%   -0.01%     
==========================================
  Files         352      352              
  Lines       31547    31547              
  Branches     4084     4083       -1     
==========================================
- Hits        19331    19328       -3     
- Misses      12216    12219       +3     
Flag Coverage Δ
unittests 61.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 force-pushed the chore/pixi-install-consistency branch from ecded36 to feb20b6 Compare November 21, 2025 15:57
@jslee02 jslee02 enabled auto-merge (squash) November 21, 2025 16:31
@jslee02 jslee02 merged commit 76461a0 into main Nov 21, 2025
35 checks passed
@jslee02 jslee02 deleted the chore/pixi-install-consistency branch November 21, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant