Skip to content

Handle URDF multidof joint limits#2233

Merged
jslee02 merged 23 commits intomainfrom
feature/urdf-multidof-limits
Nov 24, 2025
Merged

Handle URDF multidof joint limits#2233
jslee02 merged 23 commits intomainfrom
feature/urdf-multidof-limits

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 21, 2025

Apply URDF multi-DOF joint limits and parsing fixes.

  • Parses planar/floating URDF joint limits uniformly across DOFs with warnings; derives planar plane from .
  • Adds regression tests for planar/floating URDF limits and documents the semantics.
  • Closes URDF Multidimensional Joint Limits #327.

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes (relied on GitHub CI)
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@jslee02 jslee02 changed the title feature/urdf multidof limits Handle URDF multidof joint limits Nov 21, 2025
@jslee02 jslee02 added this to the DART 7.0 milestone Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 83.60656% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.90%. Comparing base (5237903) to head (7e726aa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dart/utils/urdf/DartLoader.cpp 83.60% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
+ Coverage   60.82%   60.90%   +0.07%     
==========================================
  Files         353      353              
  Lines       31880    31940      +60     
  Branches     4128     4139      +11     
==========================================
+ Hits        19392    19453      +61     
+ Misses      12488    12487       -1     
Flag Coverage Δ
unittests 60.90% <83.60%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/dynamics/GenericJoint.hpp 100.00% <ø> (ø)
dart/dynamics/detail/GenericJoint.hpp 75.69% <ø> (ø)
dart/utils/urdf/DartLoader.cpp 83.19% <83.60%> (+4.55%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 enabled auto-merge (squash) November 22, 2025 18:02
Fix planar limits initialization

Fix URDF joint lookup in DartLoader tests

Fix macOS wheel repair search path

Use action-installed pixi in publish workflow
@jslee02 jslee02 force-pushed the feature/urdf-multidof-limits branch from e1c1abf to 0236421 Compare November 22, 2025 18:34
@jslee02 jslee02 disabled auto-merge November 24, 2025 06:36
@jslee02 jslee02 merged commit 5e8ca03 into main Nov 24, 2025
3 of 30 checks passed
@jslee02 jslee02 deleted the feature/urdf-multidof-limits branch November 24, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URDF Multidimensional Joint Limits

1 participant