Skip to content

Fix Windows dartpy wheel build#2268

Merged
jslee02 merged 7 commits intomainfrom
fix/dartpy_win
Nov 25, 2025
Merged

Fix Windows dartpy wheel build#2268
jslee02 merged 7 commits intomainfrom
fix/dartpy_win

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 25, 2025

Fix Windows dartpy wheel builds on MSVC.

  • replace POSIX-only sequence counters with nb::ssize_t to match nanobind on Windows
  • keep <cstddef> includes so MSVC sees the size_t definitions during wheel builds

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes (not run; workflow-only fix)
  • Add unit tests for new functionality (not applicable)
  • Document new methods and classes (not applicable)
  • Add Python bindings (dartpy) if applicable (already existing bindings only)

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.39%. Comparing base (3c63da8) to head (e4a1234).
⚠️ Report is 244 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2268   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files         360      360           
  Lines       32623    32623           
  Branches     4281     4281           
=======================================
+ Hits        20029    20030    +1     
+ Misses      12594    12593    -1     
Flag Coverage Δ
unittests 61.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 enabled auto-merge (squash) November 25, 2025 15:51
@jslee02 jslee02 merged commit e1e2f07 into main Nov 25, 2025
41 checks passed
@jslee02 jslee02 deleted the fix/dartpy_win branch November 25, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant