Skip to content

Fix Bullet ellipsoid rolling#2274

Merged
jslee02 merged 4 commits intomainfrom
issue/868_sphere_no_roll_bullet
Nov 26, 2025
Merged

Fix Bullet ellipsoid rolling#2274
jslee02 merged 4 commits intomainfrom
issue/868_sphere_no_roll_bullet

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 26, 2025

Summary

  • fix Bullet ellipsoid rolling by using sphere shape for equal radii and a multi-sphere approximation otherwise
  • fall back to the legacy mesh only if multi-sphere creation fails
  • add a Bullet integration test that checks ellipsoid and sphere rolling on a ramp

Fixes #868


Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes (CI-only for this change)
  • Add unit tests for new functionality
  • Document new methods and classes (N/A)
  • Add Python bindings (dartpy) if applicable (N/A)

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.72%. Comparing base (f891d7e) to head (20ca884).
⚠️ Report is 239 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
+ Coverage   61.70%   61.72%   +0.02%     
==========================================
  Files         360      360              
  Lines       32520    32537      +17     
  Branches     4271     4273       +2     
==========================================
+ Hits        20067    20084      +17     
  Misses      12453    12453              
Flag Coverage Δ
unittests 61.72% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 26, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02
Copy link
Member Author

jslee02 commented Nov 26, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 merged commit e29c616 into main Nov 26, 2025
33 of 39 checks passed
@jslee02 jslee02 deleted the issue/868_sphere_no_roll_bullet branch November 26, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ellipsoids and spheres cannot roll down on a ramp with Bullet detector

1 participant