Skip to content

Handle MetaSkeleton subscriptions in CollisionGroup#2277

Merged
jslee02 merged 5 commits intomainfrom
todo/plan
Nov 26, 2025
Merged

Handle MetaSkeleton subscriptions in CollisionGroup#2277
jslee02 merged 5 commits intomainfrom
todo/plan

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 26, 2025

  • allow CollisionGroup to subscribe to any MetaSkeleton by deriving a version tag and tracking lifetime safely
  • add an integration test covering MetaSkeleton (Group) subscription membership changes and collisions
  • fix cross-platform transform initialization and casting for the new test

Before creating a pull request

  • Run pixi run test-all to lint, build, and test your changes
  • Add unit tests for new functionality
  • Document new methods and classes
  • Add Python bindings (dartpy) if applicable

@jslee02 jslee02 enabled auto-merge (squash) November 26, 2025 09:18
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.82%. Comparing base (e29c616) to head (df6b58b).
⚠️ Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
dart/collision/CollisionGroup.cpp 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
+ Coverage   61.68%   61.82%   +0.13%     
==========================================
  Files         360      360              
  Lines       32580    32592      +12     
  Branches     4280     4285       +5     
==========================================
+ Hits        20098    20150      +52     
+ Misses      12482    12442      -40     
Flag Coverage Δ
unittests 61.82% <95.65%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/collision/CollisionGroup.hpp 100.00% <ø> (ø)
dart/collision/detail/CollisionGroup.hpp 100.00% <100.00%> (ø)
dart/collision/CollisionGroup.cpp 85.40% <94.11%> (+0.65%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 merged commit 992f7a2 into main Nov 26, 2025
41 checks passed
@jslee02 jslee02 deleted the todo/plan branch November 26, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant